Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scripts: use venv for python dependencies #116

Merged
merged 4 commits into from
May 22, 2024

Conversation

NikitaZotov
Copy link
Member

No description provided.

@NikitaZotov NikitaZotov self-assigned this May 1, 2024
@NikitaZotov NikitaZotov requested review from MksmOrlov and FallenChromium and removed request for MksmOrlov May 1, 2024 09:05
@NikitaZotov NikitaZotov added this to the 0.10.0 milestone May 1, 2024
Copy link
Member

@MksmOrlov MksmOrlov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

@NikitaZotov NikitaZotov requested a review from MksmOrlov May 13, 2024 09:43
Copy link
Member

@MksmOrlov MksmOrlov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't forget about set_vars

@@ -8,8 +8,8 @@ export PLATFORM_PATH="${PLATFORM_PATH:-${ROOT_PATH}}"
export CONFIG_PATH="${CONFIG_PATH:-${PLATFORM_PATH}/ostis-web-platform.ini}"
export REPO_PATH="${REPO_PATH:-${PLATFORM_PATH}/repo.path}"

export SC_MACHINE_REPO="${SC_MACHINE_REPO:-https://github.com/ostis-ai/sc-machine.git}"
export SC_MACHINE_BRANCH="${SC_MACHINE_BRANCH:-main}"
export SC_MACHINE_REPO="${SC_MACHINE_REPO:-https://github.com/NikitaZotov/sc-machine.git}"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we shouldn't merge custom repo URL to develop

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe you did this to check CI, change this after merging ostis-ai/sc-machine#384 and ostis-ai/sc-web#169 please

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we shouldn't merge custom repo URL to develop

There is separated commit for this to test ci

@NikitaZotov NikitaZotov merged commit 07b04bf into ostis-ai:develop May 22, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants