-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
scripts: use venv for python dependencies #116
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't forget about set_vars
scripts/set_vars.sh
Outdated
@@ -8,8 +8,8 @@ export PLATFORM_PATH="${PLATFORM_PATH:-${ROOT_PATH}}" | |||
export CONFIG_PATH="${CONFIG_PATH:-${PLATFORM_PATH}/ostis-web-platform.ini}" | |||
export REPO_PATH="${REPO_PATH:-${PLATFORM_PATH}/repo.path}" | |||
|
|||
export SC_MACHINE_REPO="${SC_MACHINE_REPO:-https://github.com/ostis-ai/sc-machine.git}" | |||
export SC_MACHINE_BRANCH="${SC_MACHINE_BRANCH:-main}" | |||
export SC_MACHINE_REPO="${SC_MACHINE_REPO:-https://github.com/NikitaZotov/sc-machine.git}" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we shouldn't merge custom repo URL to develop
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe you did this to check CI, change this after merging ostis-ai/sc-machine#384 and ostis-ai/sc-web#169 please
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we shouldn't merge custom repo URL to
develop
There is separated commit for this to test ci
63149d0
to
4b1fbd1
Compare
4b1fbd1
to
ba6ee34
Compare
No description provided.