Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename conflicting params #55

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Rename conflicting params #55

wants to merge 1 commit into from

Conversation

ankke
Copy link
Collaborator

@ankke ankke commented May 26, 2023

To avoid naming conflict for some of the models lags param is renamed to n_lags. Now, n_lags param is used for pipeline configuration and should be equal to the model parameter specifying number of lags (depending on the model i.e. input_chunk_length or lags).

Similarly param model is now renamed to darts_model.

@ankke ankke self-assigned this May 26, 2023
@ankke ankke added the model all changes related to models label May 26, 2023
@codecov
Copy link

codecov bot commented May 26, 2023

Codecov Report

Merging #55 (340ec32) into main (f6df00b) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main      #55      +/-   ##
==========================================
+ Coverage   87.22%   87.23%   +0.01%     
==========================================
  Files          33       33              
  Lines        2215     2217       +2     
==========================================
+ Hits         1932     1934       +2     
  Misses        283      283              
Impacted Files Coverage Δ
tests/test_models.py 99.30% <ø> (ø)
tests/test_plotting.py 95.83% <ø> (ø)
tests/test_processing_panel_data.py 94.50% <ø> (ø)
tot/experiment.py 94.19% <100.00%> (ø)
tot/models/models_darts.py 86.74% <100.00%> (+0.32%) ⬆️

@ankke ankke marked this pull request as ready for review May 26, 2023 21:43
@ankke ankke requested a review from LeonieFreisinger May 26, 2023 21:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
model all changes related to models
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant