Using .dlext directly from Libdl rather than Base.Libc #142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This line broke for me when using ClarabelRs on Julia 1.11. In previous releases of Julia it seems at you could dlext from Base.Libc.dlext, but that is not the case on 1.11 (at least on macOS). Since Libdl is loaded here one can instead get dlext from Libdl.dlext.
|
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #142 +/- ##
===========================================
- Coverage 88.14% 88.12% -0.02%
===========================================
Files 77 77
Lines 6189 6189
===========================================
- Hits 5455 5454 -1
- Misses 734 735 +1 ☔ View full report in Codecov by Sentry. |
goulart-paul
pushed a commit
that referenced
this pull request
Jan 6, 2025
This line broke for me when using ClarabelRs on Julia 1.11. In previous releases of Julia it seems at you could dlext from Base.Libc.dlext, but that is not the case on 1.11 (at least on macOS). Since Libdl is loaded here one can instead get dlext from Libdl.dlext.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This line broke for me when using ClarabelRs on Julia 1.11.
In previous releases of Julia it seems at you could dlext from Base.Libc.dlext, but this seems to not be the case on 1.11 (at least on macOS). Since Libdl is loaded here one can instead get dlext from Libdl.dlext.