Make it a warning to overwrite (#13)

* make it a warning to overwrite * test that it did overwrite
oxinabox · Nov 12, 2018 · 619d652 · 619d652
1 parent c3cb2b9
commit 619d652
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 9 deletions.
diff --git a/src/ExpectationStubs.jl b/src/ExpectationStubs.jl
@@ -21,11 +21,6 @@ struct ExpectationValueMismatchError <: Exception
 end
 
 
-struct ExpectationAlreadySetError <:Exception
-    name
-    sig
-    argvals
-end
 
 #########################################################
 
@@ -157,7 +152,7 @@ macro expect(defn)
         ###########################################################
         # Check not already regeistered
         if haskey($(esc(name)).expectations, $(argvals))
-            throw(ExpectationAlreadySetError($(esc(name)), $(sig), $(argvals)))
+            @warn "Expectation already set" name=$(Meta.quot(name)) argvals=$(argvals) sig=$(sig)
         end
 
 

diff --git a/test/runtests.jl b/test/runtests.jl
@@ -1,14 +1,16 @@
 using ExpectationStubs
-using ExpectationStubs: ExpectationValueMismatchError, ExpectationAlreadySetError
+using ExpectationStubs: ExpectationValueMismatchError
 using Test
-
+using Test: @test_logs
 
 @testset "basic stubbing" begin
     @stub foo
     @expect(foo(::Any)=32)
     @test foo(3)==32
     @test foo(4)==32
-    @test_throws ExpectationAlreadySetError @expect(foo(::Any)=34)
+
+    @test_logs (:warn, "Expectation already set") @expect(foo(::Any)=34)
+    @test foo(5)==34
 end
 
 @testset "multitype stubbing" begin