Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate release test workflows for PyPI and Conda-forge #350

Merged
merged 14 commits into from
Dec 20, 2024

Conversation

ajjackson
Copy link
Collaborator

Closes #346

@ajjackson
Copy link
Collaborator Author

I suppose one benefit of having a test_release that calls both of these workflows would be that it already exists on master and gives a way to run these while working on them...

Copy link
Contributor

github-actions bot commented Dec 18, 2024

Test Results

    20 files  +    6      20 suites  +6   1h 23m 32s ⏱️ + 13m 40s
 1 066 tests ±    0   1 060 ✅ ±    0   6 💤 ± 0  0 ❌ ±0 
12 535 runs  +1 500  12 462 ✅ +1 485  73 💤 +15  0 ❌ ±0 

Results for commit c0aa840. ± Comparison against base commit 62be22d.

♻️ This comment has been updated with latest results.

@ajjackson ajjackson force-pushed the split-rls-tests branch 3 times, most recently from c851641 to 10b56c0 Compare December 18, 2024 20:31
@ajjackson
Copy link
Collaborator Author

Things seem to be running nicely now https://github.com/pace-neutrons/Euphonic/actions/runs/12401144969

Some concerning Windows failures but I don't think that's the workflow's fault?

Copy link

codecov bot commented Dec 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.43%. Comparing base (1f3f8c0) to head (c13c818).
Report is 10 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #350   +/-   ##
=======================================
  Coverage   95.43%   95.43%           
=======================================
  Files          29       29           
  Lines        4209     4209           
  Branches      641      641           
=======================================
  Hits         4017     4017           
  Misses        114      114           
  Partials       78       78           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ajjackson
Copy link
Collaborator Author

Hmm, the windows test failures are numerical differences of 0.005%. I'm not thrilled about them, but that's not a "cancel Christmas"-scale problem in my book. We can look at it next year and see if there is some sensitivity to Numpy versions/builds. It will be easier with this test split in place.

@ajjackson ajjackson marked this pull request as ready for review December 19, 2024 09:42
Copy link
Collaborator

@oerc0122 oerc0122 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. The #349 changes should slot right in, or be unnecessary. We'll find out once this is in.

Copy link
Contributor

github-actions bot commented Dec 20, 2024

PyPI test results

    22 files      22 suites   54m 30s ⏱️
 1 066 tests  1 060 ✅   6 💤 0 ❌
23 320 runs  23 188 ✅ 132 💤 0 ❌

Results for commit c0aa840.

♻️ This comment has been updated with latest results.

Copy link
Collaborator

@oerc0122 oerc0122 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some minor personal legibility things and symmetry. None of which are probably important.

.github/workflows/test_release_conda.yml Show resolved Hide resolved
.github/workflows/test_release_conda.yml Outdated Show resolved Hide resolved
.github/workflows/test_release_pypi.yml Show resolved Hide resolved
.github/workflows/test_release_pypi.yml Outdated Show resolved Hide resolved
ajjackson and others added 2 commits December 20, 2024 09:56
Co-authored-by: Jacob Wilkins <46597752+oerc0122@users.noreply.github.com>
Copy link
Contributor

github-actions bot commented Dec 20, 2024

Conda-forge test results

    12 files      12 suites   31m 35s ⏱️
 1 029 tests  1 019 ✅  5 💤  5 ❌
12 276 runs  12 201 ✅ 60 💤 15 ❌

For more details on these failures, see this check.

Results for commit c0aa840.

♻️ This comment has been updated with latest results.

@ajjackson
Copy link
Collaborator Author

The checks now look correct: PyPI pass and Conda-forge fail appear separately 😄

@ajjackson ajjackson merged commit daad68b into master Dec 20, 2024
27 of 31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Split release tests into separate PyPI, Conda-forge
2 participants