-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Separate release test workflows for PyPI and Conda-forge #350
Conversation
I suppose one benefit of having a |
478a9b0
to
f3cf092
Compare
c851641
to
10b56c0
Compare
Things seem to be running nicely now https://github.com/pace-neutrons/Euphonic/actions/runs/12401144969 Some concerning Windows failures but I don't think that's the workflow's fault? |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #350 +/- ##
=======================================
Coverage 95.43% 95.43%
=======================================
Files 29 29
Lines 4209 4209
Branches 641 641
=======================================
Hits 4017 4017
Misses 114 114
Partials 78 78 ☔ View full report in Codecov by Sentry. |
Hmm, the windows test failures are numerical differences of 0.005%. I'm not thrilled about them, but that's not a "cancel Christmas"-scale problem in my book. We can look at it next year and see if there is some sensitivity to Numpy versions/builds. It will be easier with this test split in place. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. The #349 changes should slot right in, or be unnecessary. We'll find out once this is in.
c13c818
to
15fd97d
Compare
PyPI test results 22 files 22 suites 54m 30s ⏱️ Results for commit c0aa840. ♻️ This comment has been updated with latest results. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just some minor personal legibility things and symmetry. None of which are probably important.
Co-authored-by: Jacob Wilkins <46597752+oerc0122@users.noreply.github.com>
Conda-forge test results 12 files 12 suites 31m 35s ⏱️ For more details on these failures, see this check. Results for commit c0aa840. ♻️ This comment has been updated with latest results. |
The checks now look correct: PyPI pass and Conda-forge fail appear separately 😄 |
Closes #346