Merge pull request #32 from logeecom/hotfix/unit-tests

Fix unit tests and release 2.0.11
packlink-dev · May 25, 2020 · 04765db · 04765db
2 parents 426d33f + 44fd22d
commit 04765db
Show file tree

Hide file tree

Showing 4 changed files with 20 additions and 4 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -3,7 +3,13 @@ All notable changes to this project will be documented in this file.
 
 The format is based on [Keep a Changelog](http://keepachangelog.com/en/1.0.0/).
 
-## [2.0.10](https://github.com/packlink-dev/ecommerce_module_core/compare/v2.0.9...v2.0.10)
+## Unreleased
+
+## [2.0.11](https://github.com/packlink-dev/ecommerce_module_core/compare/v2.0.10...v2.0.11) - 2020-05-25
+### Changed
+- Fixed unit tests
+
+## [2.0.10](https://github.com/packlink-dev/ecommerce_module_core/compare/v2.0.9...v2.0.10) - 2020-05-20
 ### Added
 - Added configuration flag for async request progress callback usage (methods
 `Configuration::isAsyncRequestWithProgress` and `Configuration::setAsyncRequestWithProgress`)

diff --git a/tests/BusinessLogic/Registration/RegistrationLegalPolicyDtoTest.php b/tests/BusinessLogic/Registration/RegistrationLegalPolicyDtoTest.php
@@ -51,7 +51,12 @@ public function testInvalidRegistrationLegalPolicy()
             $errors = $e->getValidationErrors();
             self::assertCount(2, $errors);
 
-            $errorCodes = array_map(create_function('$error', 'return $error->field;'), $errors);
+            $errorCodes = array_map(
+                function ($error) {
+                    return $error->field;
+                },
+                $errors
+            );
 
             self::assertArraySubset(array('data_processing', 'terms_and_conditions'), $errorCodes);
         }

diff --git a/tests/BusinessLogic/Registration/RegistrationRequestDtoTest.php b/tests/BusinessLogic/Registration/RegistrationRequestDtoTest.php
@@ -124,7 +124,12 @@ private function checkIfValidationExceptionIsThrown($request, $field)
             $errors = $e->getValidationErrors();
             self::assertCount(1, $errors);
 
-            $errorCodes = array_map(create_function('$error', 'return $error->field;'), $errors);
+            $errorCodes = array_map(
+                function ($error) {
+                    return $error->field;
+                },
+                $errors
+            );
 
             self::assertArraySubset(array($field), $errorCodes);
         }

diff --git a/tests/Infrastructure/Http/CurlHttpClientTest.php b/tests/Infrastructure/Http/CurlHttpClientTest.php
@@ -253,7 +253,7 @@ private function assertProgressCallback($isOn = true)
             'Curl progress callback should be set for async call.'
         );
         $this->assertFalse(
-            $curlOptions[CURLOPT_NOPROGRESS],
+            (bool)$curlOptions[CURLOPT_NOPROGRESS],
             'Curl progress callback should be set for async call.'
         );
         $this->assertTrue(