Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds method ResolveBoolWithDefault #386

Merged
merged 2 commits into from
Jan 2, 2025
Merged

Adds method ResolveBoolWithDefault #386

merged 2 commits into from
Jan 2, 2025

Conversation

dmikusa
Copy link
Contributor

@dmikusa dmikusa commented Dec 31, 2024

Summary

This allows you to fetch a boolean configuration and change the default, like if you want the default to be true. Not used often, but it is helpful for a couple of buildpacks.

Checklist

  • I have viewed, signed, and submitted the Contributor License Agreement.
  • I have linked issue(s) that this PR should close using keywords or the Github UI (See docs)
  • I have added an integration test, if necessary.
  • I have reviewed the styleguide for guidance on my code quality.
  • I'm happy with the commit history on this PR (I have rebased/squashed as needed).

@dmikusa
Adds method ResolveBoolWithDefault
97b416f 
This allows you to fetch a boolean configuration and change the default, like if you want the default to be true. Not used often, but it is helpful for a couple of buildpacks.

Signed-off-by: Daniel Mikusa <dan@mikusa.com>
@dmikusa dmikusa added type:enhancement A general enhancement semver:minor A change requiring a minor version bump labels Dec 31, 2024
@dmikusa dmikusa requested a review from a team as a code owner December 31, 2024 22:42
@dmikusa
Add test coverage
95a9e22 
Signed-off-by: Daniel Mikusa <dan@mikusa.com>
@dmikusa dmikusa merged commit 9292d28 into release-2.x Jan 2, 2025
6 checks passed
@dmikusa dmikusa deleted the add-env-bool-default branch January 2, 2025 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pivotal-david-osullivan pivotal-david-osullivan pivotal-david-osullivan approved these changes

Assignees
No one assigned
Labels
semver:minor A change requiring a minor version bump type:enhancement A general enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dmikusa @pivotal-david-osullivan