Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix new color alias #7085

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

Fix new color alias #7085

wants to merge 2 commits into from

Conversation

mud
Copy link
Contributor

@mud mud commented Nov 20, 2024

Fixes #0000

Just bumped Blueprint core to 5.15.0 and noticed there was some duplicate to the color alias where the new values were being overridden by the old duplicated variables.

Checklist

  • Includes tests
  • Update documentation

Changes proposed in this pull request:

Remove the duplicate variables that use the old dark colors

Reviewers should focus on:

Screenshot

@changelog-app
Copy link

changelog-app bot commented Nov 20, 2024

Generate changelog in packages/core/changelog/@unreleased

What do the change types mean?
  • feature: A new feature of the service.
  • improvement: An incremental improvement in the functionality or operation of the service.
  • fix: Remedies the incorrect behaviour of a component of the service in a backwards-compatible way.
  • break: Has the potential to break consumers of this service's API, inclusive of both Palantir services
    and external consumers of the service's API (e.g. customer-written software or integrations).
  • deprecation: Advertises the intention to remove service functionality without any change to the
    operation of the service itself.
  • manualTask: Requires the possibility of manual intervention (running a script, eyeballing configuration,
    performing database surgery, ...) at the time of upgrade for it to succeed.
  • migration: A fully automatic upgrade migration task with no engineer input required.

Note: only one type should be chosen.

How are new versions calculated?
  • ❗The break and manual task changelog types will result in a major release!
  • 🐛 The fix changelog type will result in a minor release in most cases, and a patch release version for patch branches. This behaviour is configurable in autorelease.
  • ✨ All others will result in a minor version release.

Type

  • Feature
  • Improvement
  • Fix
  • Break
  • Deprecation
  • Manual task
  • Migration

Description

Remove duplicate variables which overrides new dark theme secondary and elevated colors with old values.

Check the box to generate changelog(s)

  • Generate changelog entry

@svc-palantir-github
Copy link

Fix new color alias

Build artifact links for this commit: documentation | landing | table | demo

This is an automated comment from the deploy-preview CircleCI job.

@svc-palantir-github
Copy link

Add generated changelog entries

Build artifact links for this commit: documentation | landing | table | demo

This is an automated comment from the deploy-preview CircleCI job.

@ggdouglas
Copy link
Contributor

Tracking that this links back to this comment and originally added in #6724

@mud
Copy link
Contributor Author

mud commented Nov 21, 2024

Tracking that this links back to this comment and originally added in #6724

Gotcha, maybe having an inline comment suggesting the phased rollout would be useful since it currently looks like a bug.

@ashleighp13 ashleighp13 requested a review from ggdouglas December 2, 2024 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants