Skip to content

Commit

Permalink
Revert "Use in-memory http caching" (#127)
Browse files Browse the repository at this point in the history
The current cache implementation has some issues with both authenticated
requests and freshness of data, so reverting it while we work on
improvements.

This reverts commit 5bebbba.
  • Loading branch information
asvoboda authored and bluekeyes committed Jun 13, 2019
1 parent 5bebbba commit 2c872f6
Show file tree
Hide file tree
Showing 6 changed files with 2 additions and 590 deletions.
1 change: 0 additions & 1 deletion .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,5 @@
*.iml
*.ipr
*.iws
config/bulldozer.yml

build/
13 changes: 2 additions & 11 deletions Gopkg.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 0 additions & 2 deletions server/server.go
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,6 @@ package server
import (
"fmt"

"github.com/gregjones/httpcache"
"github.com/palantir/go-baseapp/baseapp"
"github.com/palantir/go-baseapp/baseapp/datadog"
"github.com/palantir/go-githubapp/githubapp"
Expand Down Expand Up @@ -54,7 +53,6 @@ func New(c *Config) (*Server, error) {
c.Github,
githubapp.WithClientUserAgent(userAgent),
githubapp.WithClientMiddleware(
githubapp.ClientCaching(func() httpcache.Cache { return httpcache.NewMemoryCache() }),
githubapp.ClientLogging(zerolog.DebugLevel),
githubapp.ClientMetrics(base.Registry()),
),
Expand Down
7 changes: 0 additions & 7 deletions vendor/github.com/gregjones/httpcache/LICENSE.txt

This file was deleted.

Loading

0 comments on commit 2c872f6

Please sign in to comment.