-
-
Notifications
You must be signed in to change notification settings - Fork 18.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ENH: Add pre-commit check for setup.cfg options.extras_require #49261
Changes from 28 commits
542b336
f9592e5
6abda3e
39e86cc
7edca5c
97adc2a
08a3e3f
4036bfe
953e885
8aed966
d079b4f
2d272c9
4f95fb2
a256dcc
52efecb
309dc97
af47477
6f6b97d
637dc10
674dadd
3c4a28e
0366b53
56c7c05
e970faa
943d5db
bace671
9f414d8
e92334d
aee587a
e5ea765
d2608b1
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -60,20 +60,19 @@ test = | |
# see: doc/source/getting_started/install.rst | ||
performance = | ||
bottleneck>=1.3.2 | ||
numba>=0.53.0 | ||
numba>=0.53.1 | ||
numexpr>=2.7.1 | ||
timezone = | ||
tzdata>=2022.1 | ||
computation = | ||
scipy>=1.7.1 | ||
xarray>=0.19.0 | ||
fss = | ||
fsspec>=2021.7.0 | ||
fsspec>=2021.07.0 | ||
aws = | ||
boto3>=1.22.7 | ||
s3fs>=0.4.0 | ||
gcp = | ||
gcsfs>=2021.05.0 | ||
gcsfs>=2021.07.0 | ||
pandas-gbq>=0.15.0 | ||
excel = | ||
odfpy>=1.4.1 | ||
|
@@ -105,7 +104,7 @@ html = | |
xml = | ||
lxml>=4.6.3 | ||
plot = | ||
matplotlib>=3.3.2 | ||
matplotlib>=3.6.1 | ||
Comment on lines
-108
to
+107
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. nice - I think older versions of matplotlib were failing the CI checks, so it's good you've caught this There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. No worries. Only caught it because of the script 😄 Thanks for reviewing and chasing up. |
||
output_formatting = | ||
jinja2>=3.0.0 | ||
tabulate>=0.8.9 | ||
|
@@ -123,19 +122,18 @@ compression = | |
all = | ||
beautifulsoup4>=4.9.3 | ||
blosc>=1.21.0 | ||
bottleneck>=1.3.1 | ||
boto3>=1.22.7 | ||
bottleneck>=1.3.2 | ||
brotlipy>=0.7.0 | ||
fastparquet>=0.4.0 | ||
fsspec>=2021.7.0 | ||
gcsfs>=2021.05.0 | ||
fastparquet>=0.6.3 | ||
fsspec>=2021.07.0 | ||
gcsfs>=2021.07.0 | ||
html5lib>=1.1 | ||
hypothesis>=5.5.3 | ||
hypothesis>=6.13.0 | ||
jinja2>=3.0.0 | ||
lxml>=4.6.3 | ||
matplotlib>=3.3.2 | ||
numba>=0.53.0 | ||
numexpr>=2.7.1 | ||
matplotlib>=3.6.1 | ||
numba>=0.53.1 | ||
numexpr>=2.7.3 | ||
odfpy>=1.4.1 | ||
openpyxl>=3.0.7 | ||
pandas-gbq>=0.15.0 | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This dependency was bumped in 1.5 to a newer version: https://pandas.pydata.org/pandas-docs/stable/whatsnew/v1.5.0.html#backwards-incompatible-api-changes
So we shouldn't be testing an older version
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was causing build issues that's why I pinned it at 0.4.0 #49261 (comment).
What is the verdict on what version we want to put in here for
s3fs
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@JMBurley cc for visibility
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @kostyafarber . I'm not sure if pandas can be built successfully with s3fs>=0.4.0 (and other packages active that require
boto3
), and I know that pandas cannot be packaged into larger production environments when it enforcess3fs>=0.4.0
because professional codebases need otherboto3
imports.However, I'm not a pandas maintainer so I don't get to make an assertion on what to pin s3fs to. @mroeschke controls the initial take on this. I'd make the pitch for not advancing the s3fs version pin, because I do not know of any benefits we need (could be a lack of awareness on my part) and I do know of major python ecosystem headaches from advancing the pin.
My team pins
s3fs<=0.4.0
versions internally for this exact reason. Ditto my colleagues controlling data science at other companies.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @JMBurley - could you please clarify about
? The
environment.yml
file has a later version ofs3fs
, and building pandas with theenvironment.yml
file works finepandas/environment.yml
Line 48 in 0b93117