Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOC/REF: Clarify pip extras dependencies & cleanups #49852

Merged
merged 3 commits into from
Nov 24, 2022

Conversation

mroeschke
Copy link
Member

Clarifying that #47336 is specifically for managing pip installation of optional dependencies

@mroeschke mroeschke added Docs Dependencies Required and optional dependencies labels Nov 23, 2022
@mroeschke mroeschke added this to the 2.0 milestone Nov 23, 2022
Copy link
Member

@MarcoGorelli MarcoGorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally looks good, just left a comment about making this cross-shell


::

pip install pandas[excel]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this won't work on mac,

Suggested change
pip install pandas[excel]
pip install "pandas[excel]"

should work everywhere

(likewise for the others)

psf/black#3254 (comment)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea! Added

@MarcoGorelli MarcoGorelli self-requested a review November 23, 2022 20:00
Copy link
Member

@MarcoGorelli MarcoGorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks @mroeschke !

@mroeschke mroeschke merged commit 0429b64 into pandas-dev:main Nov 24, 2022
@mroeschke mroeschke deleted the doc/cln/pip_extras branch November 24, 2022 18:03
mliu08 pushed a commit to mliu08/pandas that referenced this pull request Nov 27, 2022
* DOC/REF: Clarify pip extras dependencies & cleanups

* quote the install
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Dependencies Required and optional dependencies Docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants