Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ImageMagick version #8796

Merged
merged 2 commits into from
Dec 14, 2023
Merged

Update ImageMagick version #8796

merged 2 commits into from
Dec 14, 2023

Conversation

rachelwhitton
Copy link
Member

Update ImageMagick version from ImageMagick 6.9.10-86 Q16 x86_64 2020-01-13 to ImageMagick 6.9.12-93 Q16 x86_64 17898

@rachelwhitton rachelwhitton requested a review from a team as a code owner December 13, 2023 15:55
Copy link

⚡ Deployed with Pantheon Decoupled

This build was successfully deployed with Pantheon. You can track the build logs here.

👀 Preview: https://pr-8796-documentation.appa.pantheon.site
🛠️ Manage in Pantheon: https://dashboard.pantheon.io/site/2b30153f-e8b1-4427-b076-6109e704ba5d/overview

Copy link
Member

@pwtyler pwtyler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just looked, 6.9.12 matches the latest build on our php runtime.

@scottbuscemi
Copy link
Contributor

Could we link to a PHP info page instead of hard-coding the version here? https://v82-php-info.pantheonsite.io/

@rachelwhitton
Copy link
Member Author

@scottbuscemi The PHP Info link would need to be maintained similarly as hard-coded so I don't see a strong advantage for one over the other. Either way works for me so I'm happy to defer to you and @pwtyler for this decision

@scottbuscemi
Copy link
Contributor

The PHP info pages are updated automatically when any library is updated. It's pulled from the systems.

@rachelwhitton
Copy link
Member Author

@pwtyler
Copy link
Member

pwtyler commented Dec 13, 2023

@scottbuscemi Would we not eventually swap out https://v82-php-info.pantheonsite.io/ for https://v83-php-info.pantheonsite.io/ ?

eventually, but realistically only when PHP runtimes EOL, which is ~ yearly while the extension will see more frequent updates, and if we jump more than one version when that happens, it would be some time. We could do 8.3 today and be set until November 2025.

@rachelwhitton
Copy link
Member Author

@pwtyler @scottbuscemi this is helpful! thanks! i'll make it so (linking to the PHP 8.3 PHP Info page).

Do you know the right GH team to specify for this page in the CODEOWNERS file?

@pwtyler
Copy link
Member

pwtyler commented Dec 13, 2023

PHP libraries can be CMS Performance (CMS Platform on Github).

…Info page, Add external libraries to CODEOWNERS
@rachelwhitton
Copy link
Member Author

@scottbuscemi @pwtyler updated! can i get one more review round on this PR when convenient?

Copy link

⚡ Deployed with Pantheon Decoupled

This build was successfully deployed with Pantheon. You can track the build logs here.

👀 Preview: https://pr-8796-documentation.appa.pantheon.site
🛠️ Manage in Pantheon: https://dashboard.pantheon.io/site/2b30153f-e8b1-4427-b076-6109e704ba5d/overview

@rachelwhitton rachelwhitton merged commit 9b2b3de into main Dec 14, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants