-
Notifications
You must be signed in to change notification settings - Fork 678
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update ImageMagick version #8796
Conversation
⚡ Deployed with Pantheon Decoupled This build was successfully deployed with Pantheon. You can track the build logs here. 👀 Preview: https://pr-8796-documentation.appa.pantheon.site |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just looked, 6.9.12 matches the latest build on our php runtime.
Could we link to a PHP info page instead of hard-coding the version here? https://v82-php-info.pantheonsite.io/ |
@scottbuscemi The PHP Info link would need to be maintained similarly as hard-coded so I don't see a strong advantage for one over the other. Either way works for me so I'm happy to defer to you and @pwtyler for this decision |
The PHP info pages are updated automatically when any library is updated. It's pulled from the systems. |
@scottbuscemi Would we not eventually swap out https://v82-php-info.pantheonsite.io/ for https://v83-php-info.pantheonsite.io/ ? |
eventually, but realistically only when PHP runtimes EOL, which is ~ yearly while the extension will see more frequent updates, and if we jump more than one version when that happens, it would be some time. We could do 8.3 today and be set until November 2025. |
@pwtyler @scottbuscemi this is helpful! thanks! i'll make it so (linking to the PHP 8.3 PHP Info page). Do you know the right GH team to specify for this page in the CODEOWNERS file? |
PHP libraries can be CMS Performance (CMS Platform on Github). |
…Info page, Add external libraries to CODEOWNERS
@scottbuscemi @pwtyler updated! can i get one more review round on this PR when convenient? |
⚡ Deployed with Pantheon Decoupled This build was successfully deployed with Pantheon. You can track the build logs here. 👀 Preview: https://pr-8796-documentation.appa.pantheon.site |
Update ImageMagick version from
ImageMagick 6.9.10-86 Q16 x86_64 2020-01-13
toImageMagick 6.9.12-93 Q16 x86_64 17898