Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PC-33625] ne pas creer de nouvelle oa lorsque ladresse de la venue nest pas modifiee #15721

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

xordoquy-pass
Copy link
Contributor

But de la pull request

Ticket Jira (ou description si BSR) : https://passculture.atlassian.net/browse/PC-XXXXX

Vérifications

  • J'ai écrit les tests nécessaires
  • J'ai mis à jour le fichier des plans de tests du portail pro si nécessaire
  • J'ai mis à jour la liste des routes et des titres de pages du portail pro si j'en ai rajouté/modifié ou supprimé une.
  • J'ai relu attentivement les migrations, en particulier pour éviter les locks, et je préviens les équipes Shérif et Data
  • J'ai ajouté des screenshots pour d'éventuels changements graphiques
  • J'ai fait la revue fonctionnelle de mon ticket

Copy link
Contributor

github-actions bot commented Jan 6, 2025

mypy cop report: 466 (master) ↘ 465 (your branch)

Have yourself a merry little break and learn a few facts about the year 465.

Copy link
Contributor

github-actions bot commented Jan 6, 2025

Visit the preview URL for this PR (updated for commit f32cd19):

https://pc-pro-testing--pr15721-pc-33625-ne-pas-cree-82vdspog.web.app

(expires Fri, 10 Jan 2025 07:58:42 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 032d233ee67e1c50d6af12e29c936c7076770eb1

`get_offerer_address_of_offerer` was not called anywhere and looks quite
useless. Let's remove it.
@xordoquy-pass xordoquy-pass force-pushed the PC-33625-ne-pas-creer-de-nouvelle-oa-lorsque-ladresse-de-la-venue-nest-pas-modifiee branch from 2fa2485 to f32cd19 Compare January 8, 2025 07:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant