Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrating to rxjava2 #11

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jakubvimn
Copy link
Contributor

This PR updates RxJava to version 2.x
I cannot guarantee that it work (no unit tests to confirm that :( ), but if there are no null values passed to Observables, it should without any problems.

@pavlospt
Copy link
Owner

Great work once again! Although this is a breaking change. I will probably need to host 2 different versions of the library! Will keep it open until I decide on what branching model I should follow. Any thoughts on this?

@jakubvimn
Copy link
Contributor Author

There are some libraries that have different branches for different RxJava versions, like RxAndroid, but such approach requires more work for maintenance. Cutting off all the clients using RxJava1 may not be a good choice either. Maybe to best option would be using this library https://github.com/akarnokd/RxJava2Interop for backward compatibility. There are 2 options with it:

  • supporting only RxJava2 and pointing this library in README to give hope for RxJava1 users
  • using RxJava2 in the library but creating another module wrapping it with RxJava1 interface.

@pavlospt
Copy link
Owner

Yeap, that seems right, I guess I will just create another branch then and follow that strategy. Will update you tomorrow :)

@d4rken
Copy link

d4rken commented Feb 2, 2017

Any update on this?

@pavlospt
Copy link
Owner

pavlospt commented Feb 2, 2017

@d4rken Hello, none yet, did not find the time to deal with it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants