fix: handle withoutEnlargement
for undefined height
or width
#10078
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This patch implements the functionality in
imageResizer
to omit the generation of the image when either width or height is undefined andwithoutEnlargement
is set toundefined
Why?
#9986:
withoutEnlargement
doesn't work whenheight
is undefined inupload.imageSizes
How?
This code checks if
withoutEnlargement
is undefined and eithertargetWidth
ortargetHeight
is missing. If so, it further checks whether the target dimensions (if provided) are larger than the original image dimensions. If the target would enlarge the image, it returns 'omit', skipping the resizing to prevent enlargementFixes #9986