Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ui): disable save button until the upload file is uploaded / ready #10083

Open
wants to merge 14 commits into
base: main
Choose a base branch
from

Conversation

PatrikKozak
Copy link
Contributor

@PatrikKozak PatrikKozak commented Dec 19, 2024

What?

Previously, while uploading a file - if the uploading process took a bit of time, users could still save the document prior to the upload fully completing.

Why?

During the uploading process - the save button should be disabled until the upload is complete to prevent premature saving of an upload document.

How?

Now, we keep track of the state of the upload in a provider and disable the save button until the file is fully uploaded.

@PatrikKozak PatrikKozak changed the title feat(ui): disable save button until the upload file is uploaded / ready fix(ui): disable save button until the upload file is uploaded / ready Dec 23, 2024
Copy link
Contributor

@DanRibbens DanRibbens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a reason we wouldn't want to add the upload status to the existing DocumentInfoProvider? I don't see what we gain by adding another provider.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants