-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(ui): disable save button until the upload file is uploaded / ready #10083
Open
PatrikKozak
wants to merge
14
commits into
main
Choose a base branch
from
feat/upload-from-url-disabled-save
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t to the Submit button
…-from-url-disabled-save
…-from-url-disabled-save
PatrikKozak
requested review from
denolfe,
jmikrut and
DanRibbens
as code owners
December 20, 2024 19:28
…-from-url-disabled-save
…-from-url-disabled-save
…-from-url-disabled-save
PatrikKozak
changed the title
feat(ui): disable save button until the upload file is uploaded / ready
fix(ui): disable save button until the upload file is uploaded / ready
Dec 23, 2024
DanRibbens
requested changes
Dec 27, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a reason we wouldn't want to add the upload status to the existing DocumentInfoProvider? I don't see what we gain by adding another provider.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Previously, while uploading a file - if the uploading process took a bit of time, users could still save the document prior to the upload fully completing.
Why?
During the uploading process - the save button should be disabled until the upload is complete to prevent premature saving of an upload document.
How?
Now, we keep track of the state of the upload in a provider and disable the save button until the file is fully uploaded.