fix: weaken JsonObject type to allow types from payload-types being assigned to it #7815
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes that type in the website template:
payload/templates/website/src/app/components/RichText/serialize.tsx
Line 24 in 3d86bf1
Now, JsonObject still ensures that only objects can be passed, but it's weak enough to allow non-dynamic types like the ones we generate in payload-types.
The "JSON" part of this type has no meaning anymore, as it does allow objects with functions now. However, we can still use it to signal to the user that this should be JSON-serializable. It's more clear than just using Record<string, unknown>