Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: parallel processing. #56

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ooobsidian
Copy link

Parallel processing is used in the generation of speech feature files.

@philipperemy
Copy link
Owner

@ooobsidian so actually it's already using multi threading to process the audio. Just run the commands and you'll see that all your cores are used. This PR does not seem to be necessary. Let me know!

@ooobsidian
Copy link
Author

But I only have one thread in execution, and it's slow.

@philipperemy
Copy link
Owner

Hum that's weird. When I run the code, mine uses all my 12 cores.

@ooobsidian
Copy link
Author

I hope you can merge this PR, as there is only one core in use at my runtime.

@philipperemy
Copy link
Owner

But let's try to understand first why before I merged. Because in my case if I start the program with multi processes and multi threadings at the same time, it will go bad.

@ooobsidian
Copy link
Author

Anyhow, I want make it faster.

@philipperemy
Copy link
Owner

@ooobsidian sure go ahead with your implementation for now. I'll need to check that in details to understand why we have different behaviors :)

@ooobsidian
Copy link
Author

I think it should be running this program at the same time as the other programs, causing the IO to be slow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants