Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix wrong documentation url #114

Merged
merged 1 commit into from
Dec 29, 2023
Merged

Fix wrong documentation url #114

merged 1 commit into from
Dec 29, 2023

Conversation

pOmelchenko
Copy link
Contributor

Corrected the address to the documentation of the original package.

@@ -461,7 +461,7 @@
<!ENTITY url.svn.manual.status "http://svnbook.red-bean.com/en/1.2/svn.ref.svn.c.status.html">
<!ENTITY url.svn.manual.update "http://svnbook.red-bean.com/en/1.2/svn.ref.svn.c.update.html">
<!ENTITY url.svn.manual.externaldifftools "http://svnbook.red-bean.com/en/1.2/svn.advanced.externaldifftools.html">
<!ENTITY url.swoole.docs "https://www.swoole.co.uk/docs/">
<!ENTITY url.swoole.docs "https://wiki.swoole.com/">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there not an English link?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, this is a Chinese development and I noticed that they don’t really like to localize into other languages (not only in this tool)

the old link (which I am replacing) leads to some kind of fork, which is already quite different from the original swoole (as I can understand)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welp, I suppose people will figure it out.

@Girgias Girgias merged commit 6922244 into php:master Dec 29, 2023
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants