-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use RelaxNG for validation instead of DTD for DocBook 5.2 #170
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
MSTM, and I can confirm that it reports errors when I try to build the doc-en
tree as of right now using the Makefile/docker setup.
I think we need some proper error reporting for CI at least. Can we run Jing there if the build step failed? |
Ah, already tracked as php/doc-en#3912. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we also should add a license file for jing. The downloads have doc/copying.html, were we like should strip the <h2>Third-party JARs</h2>
part.
*/ | ||
$output = shell_exec('java -jar ./docbook/jing.jar ./docbook/docbook-v5.2-os/rng/docbookxi.rng .manual.xml'); | ||
if ($output === null) { | ||
echo "Command failed do you have Java installed?"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
echo "Command failed do you have Java installed?"; | |
echo "Command failed; do you have Java installed?"; |
or something (may full-stop)
I am going to need to fix the translations first, as they are violating RelaxNG. Also we need to add Java to the CI |
Isn't Java preinstalled on Ubuntu runners? (https://github.com/actions/runner-images/blob/main/images/ubuntu/Ubuntu2004-Readme.md) |
Yeah, no the issue is the usage of relative paths |
Well, need to wait for translation to sync with EN with regard to the entity removal of 33ef031 failure. |
Bigger problem is likely the MongoDB set to book conversion, although there should be PRs. |
doc-it doesn't have the MongoDB problem, but is quite out of date and doesn't build any more even with some syncing. Might need to go back to deleting some files for it to build.... |
Looking at the recent commit history of doc-it, it might make sense to disable it for the time being. |
Doc-fr is now RelaxNG compliant, Submitted some PRs to doc-ja and doc-ru but waiting for them to catch up on the DOM doc-en RelaxNG violation fixes too. |
I can probably fix doc-it by using DeepL and asking some people that I know to review it.
|
Thanks, fixed |
I'll help doc-ja to get back to building. |
Aside: the scripts on |
Yes, looks good: https://github.com/php/doc-base/actions/runs/11615325856/job/32345629762 |
Yes the only ones which don't are |
Requires php/doc-en#3911