Only checks for [skip-revcheck] at start of commit messages
#181
Conversation
|
The merge mixed ans trashed the change set. Back to draft while a fix this. |
alfsb
force-pushed
the
LOOSE_SKIP_REVCHECK
branch
from
f74fd14 to
8f710c4
Compare
alfsb
force-pushed
the
LOOSE_SKIP_REVCHECK
branch
from
8f710c4 to
e6a8e42
Compare
|
Sorry for noise. Rebased and retested. As detailed above, this fix the root cause of issue 133. Yet, this is breaking change, that impacts all translations. Listed below all files that will tracked as Old with this PR. Some or most of files may need only revtag changes. Others are real outdated files that remained untracked for almost a year. 98 files total, across all translations. This said, I do not plan to merge this, as I believe this is an editor level decision. |
|
For French, I believe @Fan2Shrek and @devnexen should be able to handle it, and I can also chime in. I know Japanese has a bunch of people now active, pinging @zonuexe, @KentarouTakeda, and @mumumu so they are aware. Russian is quite active with @saundefined and @mmalferov so I don't expect it to be a problem. ZH is usually not too behind, and it doesn't seem that problematic, but still going to ping @sy-records The file affected in PL and IT seems like even I could handle it RO is basically dead, ES is in a bad state but maybe has a bit of activity? I might go back and do some updates to it, as it is mostly just tedious markup changes that are outdated. It seems like TR is not affected too badly, so hopefully @nilgun is not too annoyed at them, and if it's only markup changes I'll see if I can do them. |
I do not expect breakages in manual builds (as this does not change |
|
The same list as above, with diff links, to more easily see what changes are to be (or already has been) applied. The worst I found by an superficial inspection is es/language/predefined/interfaces.xml diff color fr/appendices/filters.xml diff color it/language/predefined/interfaces.xml diff color ja/appendices/filters.xml diff color pl/language/predefined/interfaces.xml diff color ro/reference/mongodb/tutorial.xml diff color ru/appendices/filters.xml diff color tr/reference/filesystem/functions/stat.xml diff color uk/appendices/filters.xml diff color zh/appendices/filters.xml diff color |
|
Thank you, I synchronized it with Chinese. |
|
Addendum: after this PR is merged, the |
@jimwins is this a manual thing we need to do? |
See php/doc-base#181 for reason
See php/doc-base#181 for reason
See php/doc-base#181 for reason
See php/doc-base#181 for reason
See php/doc-base#181 for reason
See php/doc-base#181 for reason
See php/doc-base#181 for reason
|
I have synced UK, PL, RO, IT, ES. TR seems to also be in sync now. |
No, it's updated automatically at the same time that the languages are pulled and revcheck is run. That runs every hour. |
|
FR is also now updated. I think it is fine to merge this now. |
|
It's probably fine to merge. Run a quick test, merging it will bump 45 files to old status, only in 3 repos: |
This PR changes the
[skip-revcheck]function. Instead of being activated from anywhere, it only be effective if positioned at the beginning of the commit message, and ignored otherwise.This is the root cause of #133 .
This PR resolves the issue above (and avoid future cases) by changing the meaning of some commits that have
[skip-revcheck]outside of begging of commit messages. They are:The oldest commits shows that
[skip-revcheck]function is originally intended to be used from anywhere in the commit message. But most occurrences are now of accidental usage. Not only are most accidental, but all accidental occurrences are recent ones. This shows that[skip-revcheck]usage shifted from being used anywhere on commit messages.This PR does not changes the interpretation of other 142
[skip-revcheck]usages, all of them occurring at the start of commit messages.The old most accidental hashes are good examples of what I'm calling accidental usage.
f80105is a squashed commit, and9d6701is a reversion one. In both cases, these "grouping" commits includes the one liners of all grouped commits, and if one of individual commit messages contains[skip-revcheck], so this is the case with the grouped commit message.This will change files from "ok" to "old" in almost all translations. As for now, the changes are:
That is, about a hundred in total.
The Files Changed listing is a bit longer than needed, but this is because this PR depends on #180 . After it is merged, the changed set will shrink to the erasing of
backport.php, removing the functionparseIntoofGitLogParserand:Reviews and comments welcome. I also plan to write about usage of
[skip-revcheck]somewhere on https://github.com/php/doc-base/tree/master/docs . Suggestions of where?Draft state, waiting for #180 .