Avoid warnings in PHP 8.4 #212
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Girgias
reviewed
Dec 21, 2024
| @@ -19,6 +19,7 @@ | |||
|
|
|||
| require_once __DIR__ . '/all.php'; | |||
|
|
|||
| #[\AllowDynamicProperties] | |||
There was a problem hiding this comment.
Why do we allow dynamic properties at all?
There was a problem hiding this comment.
This is always be an error, but I'm stuck with 8.1.2-1ubuntu2.20 for now. There is a way to make it warn about this locally. Or, possibly, also in CI.
It turns out that the warning about the dynamic property was in fact an existing property name that was typed incorrectly.
alfsb
reviewed
Dec 21, 2024
alfsb
approved these changes
Dec 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fputcsv() escape parameter must be provided as of PHP 8.4. The other preceding parameters are also informed. Named arguments not used for backwards compatibility with PHP < 8.0.
Using
#[\AllowDynamicProperties]to the class to avoid warnings in PHP 8.2+.