[Win32Service] Update the security consideration with the 1.1.0 feature #3871
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbcr
force-pushed
the
win32service_update_security_consideration
branch
from
9b880e7 to
24f6985
Compare
cmb69
reviewed
Oct 15, 2024
cmb69
reviewed
Oct 15, 2024
There was a problem hiding this comment.
This is basically okay, but we want to avoid personalization in the documentation. Please rewrite at least the new paragraph by using passive voice.
macintoshplus
force-pushed
the
win32service_update_security_consideration
branch
from
29e8073 to
c204fb2
Compare
macintoshplus
force-pushed
the
win32service_update_security_consideration
branch
from
c204fb2 to
eaf90cd
Compare
I have rewrite the paragraph. |
Girgias
reviewed
Oct 16, 2024
|
Thank you @Girgias . I have forget some sentences. Sorry. |
Co-authored-by: Gina Peter Banyard <girgias@php.net>
macintoshplus
force-pushed
the
win32service_update_security_consideration
branch
from
63109a1 to
2df4210
Compare
No problem! It's nice to see that an extension maintainer also cares about the documentation. :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Win32Service version 1.1 improves the service's rights management. This PR updated the security consideration section to add the new feature from version 1.1.
Must be merged after php/doc-base#164
Replace #3551