-
Notifications
You must be signed in to change notification settings - Fork 757
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hooks documentation #4094
Merged
Merged
Hooks documentation #4094
Changes from all commits
Commits
Show all changes
25 commits
Select commit
Hold shift + click to select a range
4ac0873
Add basic Hooks syntax.
Crell 29720d0
Document the __PROPERTY__ magic constant.
Crell e446eff
Virtual properties.
Crell fee9be4
Include default values.
Crell eb3d539
Add references and hooks.
Crell 32bfe15
Whitespace fix.
Crell b17b1a9
Grammar fix.
Crell 08697f0
More formatting and element choices.
Crell b43fb6b
More element changes.
Crell cd28070
Move examples out of para, because apparently that's a thing?
Crell bbdafae
Fix indentation.
Crell 23975d4
Trailing whitespace.
Crell 2c87ae8
Document inheritance.
Crell 60294df
Note incompatibility with readonly.
Crell 8844314
Interface properties.
Crell 048e041
Abstract properties.
Crell 1c363a9
Discuss property variance.
Crell 642c786
Add serialization section.
Crell 7c0d3ca
More indentation fixes.
Crell ec63ee0
Tweaks and nitpicks from Girgias
Crell e4b3d22
Switch to simpara in property hooks file.
Crell eb41ec8
Use ordered list.
Crell 84d54cf
Whitespace fixes, again.
Crell d10697d
Reorder paragraphs into examples.
Crell e97e8e9
More nit picks.
Crell File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note this also adds the
T_PROPERTY_C
token to the tokenizer extension.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I... don't know what that means? Is that something relevant for the docs?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, in that it needs to be documented in the
appendices/tokens.xml
file/page :)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm going to leave this one to @iluuu1994, since he knows what it actually does.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do I still need to do something here? Are we documenting individual tokens?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
According to @Girgias, we need something about
T_PROPERTY_C
inappendices/tokens.xml
. I have no idea what that would be or what it means. I can review and merge a PR from you, however. :-)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've already documented this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you Gina!