Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor configure index test #50

Merged
merged 2 commits into from
Dec 7, 2023
Merged

Conversation

rohanshah18
Copy link
Contributor

@rohanshah18 rohanshah18 commented Dec 6, 2023

Problem

After recent changes in integration test to use the existing index if it exists, the configure index test was required to be updated to consume less resources.

Solution

  1. Refactored checkIfIndexExists code:
    a. To support both data and control plane integration tests
    b. Check if any index matches the criteria compared to old approach of checking the first index of the list and otherwise create a new index.
  2. For configure test:
    a. Updated the beforeAll logic to check if an index exist
    b. Deleted the afterEach block to delete each index and save them for future test

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • Infrastructure change (CI configs, etc)
  • Non-code change (docs, etc)
  • None of the above: (explain here)
    Added Integration tests

Test Plan

Ran integration tests locally.

@rohanshah18 rohanshah18 requested review from austin-denoble and jhamon and removed request for austin-denoble December 6, 2023 22:52
@rohanshah18 rohanshah18 marked this pull request as ready for review December 6, 2023 22:52
Copy link
Contributor

@jhamon jhamon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

@rohanshah18 rohanshah18 merged commit 5426722 into main Dec 7, 2023
8 checks passed
@rohanshah18 rohanshah18 deleted the rshah/refactorConfigureIndexTest branch December 7, 2023 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants