-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor configure index test #50
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rohanshah18
commented
Dec 6, 2023
src/integration/java/io/pinecone/PineconeIndexOperationsClientIntegrationTest.java
Show resolved
Hide resolved
rohanshah18
commented
Dec 6, 2023
rohanshah18
commented
Dec 6, 2023
rohanshah18
commented
Dec 6, 2023
src/integration/java/io/pinecone/integration/controlPlane/ConfigureIndexTest.java
Show resolved
Hide resolved
rohanshah18
commented
Dec 6, 2023
src/integration/java/io/pinecone/integration/controlPlane/ConfigureIndexTest.java
Show resolved
Hide resolved
rohanshah18
commented
Dec 6, 2023
src/integration/java/io/pinecone/integration/controlPlane/ConfigureIndexTest.java
Show resolved
Hide resolved
rohanshah18
commented
Dec 6, 2023
src/integration/java/io/pinecone/integration/controlPlane/ConfigureIndexTest.java
Show resolved
Hide resolved
rohanshah18
commented
Dec 6, 2023
rohanshah18
requested review from
austin-denoble and
jhamon
and removed request for
austin-denoble
December 6, 2023 22:52
jhamon
approved these changes
Dec 7, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work!
src/integration/java/io/pinecone/PineconeIndexOperationsClientIntegrationTest.java
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
After recent changes in integration test to use the existing index if it exists, the configure index test was required to be updated to consume less resources.
Solution
a. To support both data and control plane integration tests
b. Check if any index matches the criteria compared to old approach of checking the first index of the list and otherwise create a new index.
a. Updated the beforeAll logic to check if an index exist
b. Deleted the afterEach block to delete each index and save them for future test
Type of Change
Added Integration tests
Test Plan
Ran integration tests locally.