Skip to content

Commit

Permalink
Remove ageing transform dialect extensions (#909)
Browse files Browse the repository at this point in the history
Our own transforms are now being used as passes and the transform ops
are unmaintained for a while and not helpful any more. We plan to
restart working on transforms later on, but we'll certainly approach it
form an upstream-first mindset, so likely not to use the custom ops we
created.

However, they have served their purpose. They allowed us to experiment
with IR at a time when we didn't have such a mature dialect / pass
environment.

For those wanting to get these back, they can just revert this commit on
a branch and work with the code locally, but I strongly suggest to only
use these as a baseline, not as forward looking code.
  • Loading branch information
rengolin authored May 7, 2024
1 parent e15872f commit cf0d840
Show file tree
Hide file tree
Showing 30 changed files with 0 additions and 3,360 deletions.
1 change: 0 additions & 1 deletion include/TPP/Dialect/CMakeLists.txt
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
add_subdirectory(Check)
add_subdirectory(Perf)
add_subdirectory(Transform)
add_subdirectory(Xsmm)
6 changes: 0 additions & 6 deletions include/TPP/Dialect/Transform/CMakeLists.txt

This file was deleted.

46 changes: 0 additions & 46 deletions include/TPP/Dialect/Transform/LinalgXTransformOps.h

This file was deleted.

250 changes: 0 additions & 250 deletions include/TPP/Dialect/Transform/LinalgXTransformOps.td

This file was deleted.

2 changes: 0 additions & 2 deletions lib/TPP/DefaultPipeline.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,6 @@
#include "TPP/Dialect/Perf/BufferizableOpInterfaceImpl.h"
#include "TPP/Dialect/Perf/PerfDialect.h"
#include "TPP/Dialect/Perf/PerfOps.h"
#include "TPP/Dialect/Transform/LinalgXTransformOps.h"
#include "TPP/Dialect/Xsmm/XsmmDialect.h"
#include "TPP/PassUtils.h"
#include "mlir/Transforms/Passes.h"
Expand Down Expand Up @@ -91,7 +90,6 @@ struct DefaultPipeline : public tpp::impl::DefaultPipelineBase<DefaultPipeline>,
registry.insert<xsmm::XsmmDialect>();
registry.insert<check::CheckDialect>();
registry.insert<perf::PerfDialect>();
linalgx::registerTransformDialectExtension(registry);
check::registerBufferizableOpInterfaceExternalModels(registry);
perf::registerBufferizableOpInterfaceExternalModels(registry);

Expand Down
2 changes: 0 additions & 2 deletions lib/TPP/DefaultTppPasses.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,6 @@
#include "TPP/Dialect/Check/CheckDialect.h"
#include "TPP/Dialect/Perf/BufferizableOpInterfaceImpl.h"
#include "TPP/Dialect/Perf/PerfDialect.h"
#include "TPP/Dialect/Transform/LinalgXTransformOps.h"
#include "TPP/Dialect/Xsmm/XsmmDialect.h"
#include "TPP/PassUtils.h"

Expand Down Expand Up @@ -265,7 +264,6 @@ struct DefaultTppPasses
registry.insert<xsmm::XsmmDialect>();
registry.insert<check::CheckDialect>();
registry.insert<perf::PerfDialect>();
linalgx::registerTransformDialectExtension(registry);
check::registerBufferizableOpInterfaceExternalModels(registry);
perf::registerBufferizableOpInterfaceExternalModels(registry);

Expand Down
1 change: 0 additions & 1 deletion lib/TPP/Dialect/CMakeLists.txt
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
add_subdirectory(Check)
add_subdirectory(Perf)
add_subdirectory(Transform)
add_subdirectory(Xsmm)
20 changes: 0 additions & 20 deletions lib/TPP/Dialect/Transform/CMakeLists.txt

This file was deleted.

Loading

0 comments on commit cf0d840

Please sign in to comment.