Zero initialization as beta=0 during fusion #902
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KavithaTipturMadhu
changed the title
adam-smnk
reviewed
Mar 21, 2024
lib/TPP/Transforms/LinalgConvertCompareSelectToMaximumfPass.cpp
Outdated
Show resolved
Hide resolved
|
Any impact on benchmarks? |
KavithaTipturMadhu
force-pushed
the
zero
branch
from
b8a5e03 to
2894c9d
Compare
Will have impact on benchmarks and tests, will add some unit tests at least. |
rengolin
reviewed
Mar 21, 2024
adam-smnk
reviewed
Mar 21, 2024
rengolin
changed the title
rengolin
reviewed
Mar 27, 2024
There was a problem hiding this comment.
This is really good, thank you @KavithaTipturMadhu, and sorry for the delay. This week is being a bit tough.
I only have two nits and it should be good to merge.
rengolin
approved these changes
Mar 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#897 (comment)