Fix VNNI affine maps #998
Merged
Fix VNNI affine maps #998
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adam-smnk
force-pushed
the
fix-vnni-affine-maps
branch
from
8d18e4c to
9f400b5
Compare
adam-smnk
added
benchmark
|
No benchmark regressions. |
adam-smnk
commented
Jan 6, 2025
rengolin
reviewed
Jan 8, 2025
rengolin
reviewed
Jan 9, 2025
rengolin
reviewed
Jan 9, 2025
rengolin
approved these changes
Jan 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Retires incorrect VNNI affine map representation using
floordiv 2and replaces it with an extra separate VNNI dimension in matrix operand A:expand <M x K> into <M x K/VNNI x VNNI>.The updated VNNI representation is propagated through matchers, lowerings, and tests.
A new test is added to ensure correct results between Linalg to SCF loops and XSMM lowering.