-
Notifications
You must be signed in to change notification settings - Fork 148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Exp/libp2p #3996
Draft
greymistcube
wants to merge
28
commits into
planetarium:5.3-maintenance
Choose a base branch
from
greymistcube:exp/libp2p
base: 5.3-maintenance
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Exp/libp2p #3996
greymistcube
wants to merge
28
commits into
planetarium:5.3-maintenance
from
greymistcube:exp/libp2p
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
greymistcube
force-pushed
the
exp/libp2p
branch
from
November 25, 2024 07:14
a9418a1
to
58a4a6b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Leaving it as a draft for future reference.
While working on this, I have run into several problems:
dotnet-libp2p
:IRemotePeer.DialAsync<T>()
is not properly cancellable. It is impossible to timeout with aCancellationToken
.IServiceProvider
uses severalstatic
variables to track services provided. Most notably, the instance ofIProtocol
is stored in astatic
HashSet<T>
. A service of typeT
is retrieved only by its type, hence it is impossible to have severalIServiceProvider
s for multipleITransport
s for unit testing.libplanet
:dotnet-libp2p
stack is designed to have persistent connection between separate peers. That is, to continuously have a channel open withIRemotePeer
obtained viaILocalPeer.DialAsync()
. The issue may be with the underlying implementation ofIServiceProvider
on thedotnet-libp2p
side, but regardless, parallel or subsequent calls to a same peer seem very unreliable.