Skip to content

Commit

Permalink
Fix incorrect handling of positional linker flags
Browse files Browse the repository at this point in the history
Resolves #1430
  • Loading branch information
valeros committed Jul 30, 2024
1 parent e519b92 commit cb702f4
Showing 1 changed file with 3 additions and 1 deletion.
4 changes: 3 additions & 1 deletion builder/frameworks/espidf.py
Original file line number Diff line number Diff line change
Expand Up @@ -1595,7 +1595,9 @@ def get_python_exe():

# Extra flags which need to be explicitly specified in LINKFLAGS section because SCons
# cannot merge them correctly
extra_flags = filter_args(link_args["LINKFLAGS"], ["-T", "-u"])
extra_flags = filter_args(
link_args["LINKFLAGS"], ["-T", "-u", "-Wl,--start-group", "-Wl,--end-group"]
)
link_args["LINKFLAGS"] = sorted(list(set(link_args["LINKFLAGS"]) - set(extra_flags)))

# remove the main linker script flags '-T memory.ld'
Expand Down

0 comments on commit cb702f4

Please sign in to comment.