Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Mklib now deletes correctly all the tmpfile:
I have changed back:
tmpfile=$(mktemp ${file%.cpp}.XXXXXX).cpp
that creates a tmpfile WITHOUT the .cpp extension, but savestmpfile
with the .cpp extension to be manipulated by the scriptinto:
tmpfile=$(mktemp ${file%.cpp}.XXXXXX.cpp)
creates a tmp .cpp file that will be correctly deleted afterThis patch was though for the single file mklib, and we must note that do NOT patch an eventual header file with the old paths in it
Target release
I would like my code to appear in the next 2.9 patch /in 2.10
Type of contribution
Copyright
COPYRIGHT
file with the correct license information. Code should be released under an open source license. I also used the commandcd src && ./header.sh mymodulename
in order to make sure the headers of the module are correct.Tests