Add test should not pass null key

.circleci/config.yml

@@ -0,0 +1,51 @@
+version: 2.1
+
+jobs:
+  unittest:
+    parameters:
+      php-version:
+        type: string
+      plugin-name:
+        type: string
+        default: "get"
+    docker:
+      - image: hillliu/pmvc-phpunit:<< parameters.php-version >>
+    working_directory: /var/www/<< parameters.plugin-name >>
+    steps:
+      - checkout
+      - run:
+          name: "Display information"
+          command: |
+            date
+            php -v
+            php -m
+            php -r "if(function_exists('gd_info'))print_r(gd_info());"
+            composer --version
+            phpunit --version
+      - run:
+          name: Composer install packages
+          command: |
+            composer update
+            composer install --prefer-source
+      - run:
+          name: PHPUnit
+          command: |
+            ENABLE_COVERAGE=false
+            if [ "<< parameters.php-version >>" == "8.1" ] && [ "$ENABLE_COVERAGE" == "true" ]; then
+              XDEBUG_MODE=coverage phpunit --coverage-clover clover.xml
+              coveralls --coverage_clover=clover.xml -v -o coveralls-upload.json
+            else
+              phpunit
+            fi
+      - store_artifacts:
+          path: /var/www/<< parameters.plugin-name >>/clover.xml
+      - store_artifacts:
+          path: /var/www/<< parameters.plugin-name >>/coveralls-upload.json
+
+workflows:
+  run-job:
+    jobs:
+      - unittest:
+          matrix:
+            parameters:
+              php-version: ["8.1", "8.0",  "5.6"]

.gitignore

@@ -1,4 +1,5 @@
 vendor
 composer.lock
 .php_cs.cache
+.phpunit.result.cache
 .*.sw?

README.md

@@ -1,6 +1,6 @@
 [![Latest Stable Version](https://poser.pugx.org/pmvc-plugin/get/v/stable)](https://packagist.org/packages/pmvc-plugin/get) 
 [![Latest Unstable Version](https://poser.pugx.org/pmvc-plugin/get/v/unstable)](https://packagist.org/packages/pmvc-plugin/get) 
-[![Build Status](https://travis-ci.org/pmvc-plugin/get.svg?branch=master)](https://travis-ci.org/pmvc-plugin/get)
+[![CircleCI](https://circleci.com/gh/pmvc-plugin/get/tree/master.svg?style=svg)](https://circleci.com/gh/pmvc-plugin/get/tree/master)
 [![License](https://poser.pugx.org/pmvc-plugin/get/license)](https://packagist.org/packages/pmvc-plugin/get)
 [![Total Downloads](https://poser.pugx.org/pmvc-plugin/get/downloads)](https://packagist.org/packages/pmvc-plugin/get) 
 

composer.json

@@ -1,17 +1,20 @@
 {
-    "name": "pmvc-plugin/get",
-    "description": "smart get function, help you get configure from different storage simply. ",
-    "type": "library",
-    "keywords": ["get", "pmvc", "plug-in"],
-    "license": "MIT",
-    "authors": [
-        {
-            "name": "Hill",
-            "email": "hill@kimo.com"
-        }
-    ],
-    "require": {
-        "pmvc/pmvc": "*"
-    },
-    "minimum-stability": "dev"
+  "name": "pmvc-plugin/get",
+  "description": "smart get function, help you get configure from different storage simply. ",
+  "type": "library",
+  "keywords": ["get", "pmvc", "plug-in"],
+  "license": "MIT",
+  "authors": [
+    {
+      "name": "Hill",
+      "email": "hill@kimo.com"
+    }
+  ],
+  "require": {
+    "pmvc/pmvc": "*"
+  },
+  "require-dev": {
+    "pmvc-plugin/unit": "*"
+  },
+  "minimum-stability": "dev"
 }

get.php

@@ -9,15 +9,18 @@
 /**
  * Put this outside class, so we don't need init it in very begin
  */
-\PMVC\l(__DIR__.'/src/GetInterface.php');
+\PMVC\l(__DIR__ . '/src/GetInterface.php');
 
-${_INIT_CONFIG}[_CLASS] = __NAMESPACE__.'\get';
+${_INIT_CONFIG}[_CLASS] = __NAMESPACE__ . '\get';
 
 class get extends PlugIn
 {
     public function get($k, $default = null)
     {
-        $result =& \PMVC\getOption($k);
+        if (is_null($k)) {
+            $this->unexpected_key_exception();
+        }
+        $result = &\PMVC\getOption($k);
         if (is_null($result)) {
             foreach ($this[GET_ORDER] as $get) {
                 $plug = \PMVC\plug($get);
@@ -42,15 +45,15 @@ public function get($k, $default = null)
     public function init()
     {
         if (!is_array($this[GET_ORDER])) {
-            $this->unexpected_order_value_exception($this[GET_ORDER]); 
+            $this->unexpected_order_value_exception($this[GET_ORDER]);
         }
     }
 
     public function offsetSet($k, $v)
     {
         if ($k === GET_ORDER && !is_array($v)) {
-            $this->unexpected_order_value_exception($v); 
-        } 
+            $this->unexpected_order_value_exception($v);
+        }
         return parent::offsetSet($k, $v);
     }
 }

src/_unexpected_key_exception.php

@@ -0,0 +1,16 @@
+<?php
+
+namespace PMVC\PlugIn\get;
+
+use UnexpectedValueException;
+
+${_INIT_CONFIG}[_CLASS] = __NAMESPACE__.'\UnexpectedKeyException';
+
+class UnexpectedKeyException
+{
+    public function __invoke()
+    {
+        $message = '[PlugIn:get] should not pass key with null';
+        throw new UnexpectedValueException($message);
+    }
+}

tests/include.php

@@ -1,18 +1,11 @@
 <?php
 
-$path = __DIR__.'/../vendor/autoload.php';
+$path = __DIR__ . '/../vendor/autoload.php';
 include $path;
 
-if (!class_exists('PHPUnit_Framework_TestCase')) {
-    class PHPUnit_Framework_TestCase extends
-        \PHPUnit\Framework\TestCase
-    {
-    }
-    class PHPUnit_Framework_Error extends
-        \PHPUnit\Framework\Error\Notice
-    {
-    }
-}
-
-\PMVC\Load::plug();
-\PMVC\addPlugInFolders([__DIR__.'/../../']);
+\PMVC\Load::plug(
+    [
+        'unit' => null,
+    ],
+    [__DIR__ . '/../../']
+);

tests/test.php

@@ -2,17 +2,31 @@
 
 namespace PMVC\PlugIn\get;
 
-use PHPUnit_Framework_TestCase;
+use PMVC\TestCase;
 
-class GetTest extends PHPUnit_Framework_TestCase
+const emptyOrder = ['order' => []];
+
+class GetTest extends TestCase
 {
-    private $_plug='get';
-    function testPlugin()
+    private $_plug = 'get';
+    public function testPlugin()
     {
         ob_start();
-        print_r(\PMVC\plug($this->_plug, ['order'=>[]]));
+        print_r(\PMVC\plug($this->_plug, emptyOrder));
         $output = ob_get_contents();
         ob_end_clean();
-        $this->assertContains($this->_plug,$output);
+        $this->haveString($this->_plug, $output);
+    }
+
+    /**
+     * @expectedException        UnexpectedValueException
+     * @expectedExceptionMessage should not pass key with null
+     */
+    public function testGetNullKey()
+    {
+        $get = \PMVC\plug($this->_plug, emptyOrder);
+        $this->willThrow(function () use ($get) {
+            $get->get(null);
+        }, false);
     }
 }