refactor(message response): convert to functional component #1541
Conversation
ajohn25
force-pushed
the
refactor-message-response
branch
from
c961e6e to
0eb79ea
Compare
ajohn25
force-pushed
the
refactor-message-response
branch
from
0eb79ea to
e4ad01e
Compare
| const { data } = await sendMessage({ | ||
| variables: { message, campaignContactId: contact.id as string } | ||
| }); | ||
| const messages = data?.sendMessage?.messages; | ||
|
|
||
| if (messages) { | ||
| props.messagesChanged(messages); | ||
| props.onChange?.(""); | ||
| } | ||
| } catch (e: any) { | ||
| setSendError(e.message); |
There was a problem hiding this comment.
Required: take this opportunity to handle errors property in GraphQL response (these errors will not be thrown)
| const { data } = await sendMessage({ | |
| variables: { message, campaignContactId: contact.id as string } | |
| }); | |
| const messages = data?.sendMessage?.messages; | |
| if (messages) { | |
| props.messagesChanged(messages); | |
| props.onChange?.(""); | |
| } | |
| } catch (e: any) { | |
| setSendError(e.message); | |
| const { data, errors } = await sendMessage({ | |
| variables: { message, campaignContactId: contact.id as string } | |
| }); | |
| const messages = data?.sendMessage?.messages; | |
| if (errors) ... | |
| if (messages) { | |
| props.messagesChanged(messages); | |
| props.onChange?.(""); | |
| } | |
| } catch (e: any) { | |
| setSendError(e.message); |
There was a problem hiding this comment.
Can you say more about the errors that won't get thrown/caught here? This GraphQL error for example does get caught successfully currently
There was a problem hiding this comment.
That's a server-side log, correct?
The client-side call to await sendMessage() won't throw. While the error is logged server-side, client-side the operation returns with both data and errors properties and leaves it up to the user to decide how they want to handle the error condition(s).
There was a problem hiding this comment.
Mixed myself up between versions of code 🤦🏾♂️ fix is in!
There was a problem hiding this comment.
All good!
As an aside (definitely beyond scope of this PR), I added another to-do on the conventions task for standardizing how we display GraphQL errors. cc @hiemanshu
...rs/AdminIncomingMessageList/components/IncomingMessageList/MessageColumn/MessageResponse.tsx
Outdated
Show resolved
Hide resolved
| }; | ||
|
|
||
| export default loadData({ mutations })(MessageResponse); |
| isSending: false, | ||
| sendError: "" | ||
| }; | ||
| const MessageResponse: React.FC<MessageResponseProps> = (props) => { |
There was a problem hiding this comment.
suggestion: expand props to { conversation, value, onChange, messagedChanged } easier to access without props.<something>
Description
This converts the message response component in message review to a functional component
Motivation and Context
Best practices, better support for codegen in this component for #1526
How Has This Been Tested?
This has been tested locally
Screenshots (if appropriate):
Documentation Changes
Checklist: