Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VIAC French import for PDF Extractor, basic tests #3631

Closed
wants to merge 22 commits into from

Conversation

denispol
Copy link
Contributor

@denispol denispol commented Nov 6, 2023

Adding PDF Importer for WirBank documents (VIAC) in French (only English and German are supported in current release)

@Nirus2000 Nirus2000 added the pdf label Nov 6, 2023
denispol and others added 3 commits November 6, 2023 10:12
…ansfer/pdf/wirbank/WirBankPDFExtractorTest.java

Co-authored-by: Nirus2000 <45203494+Nirus2000@users.noreply.github.com>
…ansfer/pdf/wirbank/WirBankPDFExtractorTest.java

Co-authored-by: Nirus2000 <45203494+Nirus2000@users.noreply.github.com>
…ansfer/pdf/wirbank/WirBankPDFExtractorTest.java

Co-authored-by: Nirus2000 <45203494+Nirus2000@users.noreply.github.com>
@denispol
Copy link
Contributor Author

denispol commented Nov 6, 2023

Thank you for reviewing, I am not really knowledgeable in Java, made this PR to get VIAC imports working in French

denispol and others added 18 commits November 6, 2023 10:17
…/pdf/WirBankPDFExtractor.java

Co-authored-by: Nirus2000 <45203494+Nirus2000@users.noreply.github.com>
…/pdf/WirBankPDFExtractor.java

Co-authored-by: Nirus2000 <45203494+Nirus2000@users.noreply.github.com>
…/pdf/WirBankPDFExtractor.java

Co-authored-by: Nirus2000 <45203494+Nirus2000@users.noreply.github.com>
…/pdf/WirBankPDFExtractor.java

Co-authored-by: Nirus2000 <45203494+Nirus2000@users.noreply.github.com>
…/pdf/WirBankPDFExtractor.java

Co-authored-by: Nirus2000 <45203494+Nirus2000@users.noreply.github.com>
…/pdf/WirBankPDFExtractor.java

Co-authored-by: Nirus2000 <45203494+Nirus2000@users.noreply.github.com>
…/pdf/WirBankPDFExtractor.java

Co-authored-by: Nirus2000 <45203494+Nirus2000@users.noreply.github.com>
…/pdf/WirBankPDFExtractor.java

Co-authored-by: Nirus2000 <45203494+Nirus2000@users.noreply.github.com>
…/pdf/WirBankPDFExtractor.java

Co-authored-by: Nirus2000 <45203494+Nirus2000@users.noreply.github.com>
…/pdf/WirBankPDFExtractor.java

Co-authored-by: Nirus2000 <45203494+Nirus2000@users.noreply.github.com>
…/pdf/WirBankPDFExtractor.java

Co-authored-by: Nirus2000 <45203494+Nirus2000@users.noreply.github.com>
…/pdf/WirBankPDFExtractor.java

Co-authored-by: Nirus2000 <45203494+Nirus2000@users.noreply.github.com>
…/pdf/WirBankPDFExtractor.java

Co-authored-by: Nirus2000 <45203494+Nirus2000@users.noreply.github.com>
…/pdf/WirBankPDFExtractor.java

Co-authored-by: Nirus2000 <45203494+Nirus2000@users.noreply.github.com>
…/pdf/WirBankPDFExtractor.java

Co-authored-by: Nirus2000 <45203494+Nirus2000@users.noreply.github.com>
…/pdf/WirBankPDFExtractor.java

Co-authored-by: Nirus2000 <45203494+Nirus2000@users.noreply.github.com>
…/pdf/WirBankPDFExtractor.java

Co-authored-by: Nirus2000 <45203494+Nirus2000@users.noreply.github.com>
…/pdf/WirBankPDFExtractor.java

Co-authored-by: Nirus2000 <45203494+Nirus2000@users.noreply.github.com>
@Nirus2000 Nirus2000 self-requested a review November 6, 2023 09:22
@Nirus2000
Copy link
Member

Nirus2000 commented Nov 6, 2023

Hello @denispol
Your pull request looks very good... there are a few small things that need to be adjusted.
But TOP !!! 👍🏻 👍🏻 👍🏻

All special characters in a string are to be replaced with a dot as a regular expression. So the { [ ( | ) ] } * + ? \ . ' ^´´ `` ... in the source are to be escaped. (Escaping = \\.)

If you have time... check the rest of your source...

And that's all... VERY VERY GOOD... !!

Regards Alex

@Nirus2000 Nirus2000 removed their request for review November 6, 2023 09:35
buchen pushed a commit that referenced this pull request Nov 7, 2023
Squashed, rebased, and fixed some error in #3631

Co-Authored-By: Nirus2000 <45203494+Nirus2000@users.noreply.github.com>
Co-Authored-By: denispol <abouveur@tuta.io>
buchen added a commit that referenced this pull request Nov 7, 2023
@buchen
Copy link
Member

buchen commented Nov 7, 2023

Thanks @denispol for the contribution
and thank you very much to @Nirus2000 for shepherding the pull request into the source (#3633)

It is now merged.

@buchen buchen closed this Nov 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants