New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for changed BankIdentifier to Sunrise PDF-Importer #4404

Merged

Nirus2000 merged 2 commits into portfolio-performance:master from kriegerse:fix_SunrisePDFExtractor

Dec 21, 2024

Contributor

kriegerse commented Dec 20, 2024 •

edited by Nirus2000

Loading

Issue: #4405
Closes #4405

Fix the PDF import for Sunrise which changed the BankIdentifier.

It will:

add two new BankIdentifiers: info@sunrise.app + Sunrise Securities GmbH used within the PDFs
add testCase for the changed PDF


          Add support for changed BankIdentifier to Sunrise PDF-Importer

a5f8a7a

kriegerse marked this pull request as ready for review

December 20, 2024 18:02


          fix missing semicolon

7bcb185

Nirus2000 added the pdf label

Nirus2000 merged commit 1e4f7b4 into portfolio-performance:master

2 checks passed

Member

Nirus2000 commented Dec 21, 2024

Hello @kriegerse
nice... good job!!

kriegerse deleted the fix_SunrisePDFExtractor branch

December 21, 2024 09:21

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pdf