Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parse errors probably shouldn't trigger toast notifs during document formatting #65

Open
DavisVaughan opened this issue Nov 26, 2024 · 0 comments · May be fixed by #120
Open

Parse errors probably shouldn't trigger toast notifs during document formatting #65

DavisVaughan opened this issue Nov 26, 2024 · 0 comments · May be fixed by #120

Comments

@DavisVaughan
Copy link
Collaborator

Image

It's fairly annoying to get toast notifs when you have a syntax error in the code. I think we should probably silently log in this particular case since we "refuse" to format in the presence of parse errors - it's not really an error case, it's an expected case with known behavior.

For example, ruff special cases syntax/parse errors as logged warnings, but not LSP Errors
https://github.com/astral-sh/ruff/blob/82c01aa6623b7d4df1e4f06cb2889059f287336f/crates/ruff_server/src/format.rs#L24-L28

@DavisVaughan DavisVaughan changed the title Parse errors probably shouldn't trigger toast notifs Parse errors probably shouldn't trigger toast notifs during document formatting Nov 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant