Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #90
Closes #123
Follow up to #78
--check
to work correctly, and allowing us to take advantage of an optimization where we detect that no changes occurred during the formattingNone
in the response to the format request if we detect no changes, rather than running an expensive diff algorithm)As mentioned in #90, our parser and Biome's formatter are happy with alternative line endings when they appear in the trivia, but if non-unix line endings appear in a token then the formatter panics. This happens in multiline strings, so we now normalize strings efficiently using a
Cow::Borrowed
when nothing changed.The way this all flows through biome is (as implemented by rome/tools#1672):
LineEnding
The last step there is why the Printer doesn't allow any non-Unix line endings internally. It really just looks for
\n
at print time to decide when to applyLineEnding
, so\r\n
would make it behave incorrectly.