-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add CI #69
Add CI #69
Conversation
Hmm that's this test
but that's interesting because this file was created on a mac where Regardless this feels like an interesting restriction for multiline/raw strings On the windows vm
I can see that biome does have some multiline string tests However they also set gitattributes that ensure those files are checked out with LF endings See also rome/tools#2060 |
Ah interesting it looks like If you look at usage of that, its in So it looks like biome handles inputs with multiline strings containing It looks like biome has some kind of invariant built in where it doesn't allow i.e. in a case like this you are supposed to end up with this interesting mix of line endings on windows
But maybe this is a good thing? Right? Like, if you execute that multiline string right now, then on some platforms you get a string containing Ruff PR astral-sh/ruff#5451 Right now my plan is to also implement this, but in another PR. I'll comment out the test so we can merge |
This is critical for parser tests to run on Windows. Otherwise git will check them out with `\r\n` endings and you'll see a snapshot diff in the parser tests. It's what ruff and biome both do. We will also need this file to explicitly declare `eof=crlf` on files when we want to add crlf specific tests
It had CRLF endings for some reason
No description provided.