Skip to content

Commit

Permalink
Turn on more plots tests for windows (#5530)
Browse files Browse the repository at this point in the history
### Intent
Some issue were fixed to allow more plots tests to pass on windows

### Approach

Added the `@win` tag and a comment as to why other tests aren't running on windows.

### QA Notes
All tagged tests should pass
<!--
  Add additional information for QA on how to validate the change,
  paying special attention to the level of risk, adjacent areas that
  could be affected by the change, and any important contextual
  information not present in the linked issues.
-->
  • Loading branch information
jonvanausdeln authored Nov 27, 2024
1 parent f53a9d1 commit 3aafe05
Showing 1 changed file with 5 additions and 4 deletions.
9 changes: 5 additions & 4 deletions test/smoke/src/areas/positron/plots/plots.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@ test.use({
});

test.describe('Plots', () => {
// Some tests are not tagged @win because they woould require a new master image.
test.describe('Python Plots', () => {
test.beforeEach(async function ({ app, interpreter }) {
// Set the viewport to a size that ensures all the plots view actions are visible
Expand Down Expand Up @@ -138,7 +139,7 @@ test.describe('Plots', () => {
await expect(plots.plotSizeButton).not.toBeDisabled();
});

test('Python - Verifies saving a Python plot [C557005]', async function ({ app, logger }) {
test('Python - Verifies saving a Python plot [C557005]', { tag: ['@win'] }, async function ({ app, logger }) {
logger.log('Sending code to console');
await app.workbench.positronConsole.executeCode('Python', savePlot, '>>>');
await app.workbench.positronPlots.waitForCurrentPlot();
Expand All @@ -149,7 +150,7 @@ test.describe('Plots', () => {
await app.workbench.positronExplorer.waitForProjectFileToAppear('Python-scatter.jpeg');
});

test('Python - Verifies bqplot Python widget [C720869]', { tag: ['@web'] }, async function ({ app }) {
test('Python - Verifies bqplot Python widget [C720869]', { tag: ['@web', '@win'] }, async function ({ app }) {
await runScriptAndValidatePlot(app, bgplot, '.svg-figure');
});

Expand Down Expand Up @@ -197,7 +198,7 @@ test.describe('Plots', () => {
expect(lines).not.toContain('Hello, world!');
});

test('Python - Verifies bokeh Python widget [C730343]', { tag: ['@web'] }, async function ({ app }) {
test('Python - Verifies bokeh Python widget [C730343]', { tag: ['@web', '@win'] }, async function ({ app }) {
await app.workbench.positronConsole.pasteCodeToConsole(bokeh);
await app.workbench.positronConsole.sendEnterKey();

Expand Down Expand Up @@ -283,7 +284,7 @@ test.describe('Plots', () => {
await app.workbench.positronPlots.waitForNoPlots();
});

test('R - Verifies saving an R plot [C557006]', async function ({ app, logger }) {
test('R - Verifies saving an R plot [C557006]', { tag: ['@win'] }, async function ({ app, logger }) {
logger.log('Sending code to console');

await app.workbench.positronConsole.executeCode('R', rSavePlot, '>');
Expand Down

0 comments on commit 3aafe05

Please sign in to comment.