Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't refresh variables on every console execution #5871

Merged
merged 2 commits into from
Jan 7, 2025
+8 −1
Merged

Don't refresh variables on every console execution #5871

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
46fb8b4
don't refresh variables on every console execution
jmcphers Jan 2, 2025
166eb1a
Merge remote-tracking branch 'origin/main' into bugfix/variables-rpc-…
jmcphers Jan 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion src/vs/workbench/services/positronVariables/common/positronVariablesService.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -372,13 +372,20 @@ export class PositronVariablesService extends Disposable implements IPositronVar

const { sessionId } = session;

// No-op if this is already the active instance. Setting the active
// instance below triggers a refresh, so avoid it if if the instance is
// already active.
if (this._activePositronVariablesInstance?.session.sessionId === sessionId) {
return;
}

const positronVariablesInstance = this._positronVariablesInstancesBySessionId.get(
sessionId
);

if (positronVariablesInstance) {
this._setActivePositronVariablesInstance(positronVariablesInstance);
return
return;
}

this._logService.error(`Cannot show Variables: ${formatLanguageRuntimeSession(session)} became active, but a Variables instance for it is not running.`);
Expand Down
Loading