Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Data Explorer: Support opening gzipped csv files with DuckDB by decompressing in memory in NodeJS #5901

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

wesm
Copy link
Contributor

@wesm wesm commented Jan 7, 2025

Addresses #5332. This works around duckdb-wasm's limitation that it cannot read directly from gzipped CSV/TSV files by unzipping in memory and registering as a virtual file. This is okay for small files but for very large gzipped files will feel a bit slow and use a bunch of memory (we will have to tackle that problem via #5889).

Release Notes

New Features

Bug Fixes

  • N/A

e2e: @:data-explorer

Copy link

github-actions bot commented Jan 7, 2025

E2E Tests 🚀  ?
This PR will run tests tagged with: @critical @data-explorer

@wesm wesm requested a review from juliasilge January 7, 2025 21:00
Copy link
Contributor

@juliasilge juliasilge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With this PR, I can open a gzipped CSV or TSV file in a Data Explorer tab, and I see consistent updating behavior when the underlying file is changed. ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants