Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix release profile build #35

Merged
merged 1 commit into from
Dec 5, 2023
Merged

Fix release profile build #35

merged 1 commit into from
Dec 5, 2023

Conversation

geofjamg
Copy link
Member

@geofjamg geofjamg commented Dec 5, 2023

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Does this PR already have an issue describing the problem?

No

What kind of change does this PR introduce?

Bug fix

What is the current behavior?

When building with -Prelease we get on error on test sources build.

What is the new behavior (if this is a feature change)?
We moved the cpp sources to not collide with test ones in maven build helper plugin.

Does this PR introduce a breaking change or deprecate an API?

  • Yes
  • No

If yes, please check if the following requirements are fulfilled

  • The Breaking Change or Deprecated label has been added
  • The migration steps are described in the following section

What changes might users need to make in their application due to this PR? (migration steps)

Other information:

Signed-off-by: Geoffroy Jamgotchian <geoffroy.jamgotchian@rte-france.com>
@geofjamg geofjamg merged commit c197816 into main Dec 5, 2023
6 checks passed
@geofjamg geofjamg deleted the fix_cpp_src branch December 5, 2023 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant