Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split mount and patch #4567

Draft
wants to merge 4 commits into
base: v11-2
Choose a base branch
from
Draft

Split mount and patch #4567

wants to merge 4 commits into from

Conversation

JoviDeCroock
Copy link
Member

@JoviDeCroock JoviDeCroock commented Nov 23, 2024

This is a heavy Work in progress but it will serve as the first step to reviving the work for backing-nodes. Don't worry about the byte-size here yet, this is currently convoluted and will enable a lot of work like tree-shakeable class components.

Copy link

github-actions bot commented Nov 23, 2024

📊 Tachometer Benchmark Results

Summary

⏳ Benchmarks are currently running. Results below are out of date.

duration

  • create10k: unsure 🔍 -0% - +1% (-2.94ms - +6.61ms)
    preact-local vs preact-main
  • filter-list: unsure 🔍 -0% - +1% (-0.05ms - +0.16ms)
    preact-local vs preact-main
  • hydrate1k: unsure 🔍 -2% - +0% (-1.29ms - +0.25ms)
    preact-local vs preact-main
  • many-updates: slower ❌ 2% - 7% (0.33ms - 1.19ms)
    preact-local vs preact-main
  • replace1k: slower ❌ 4% - 5% (2.41ms - 3.60ms)
    preact-local vs preact-main
  • text-update: slower ❌ 15% - 39% (0.36ms - 0.82ms)
    preact-local vs preact-main
  • todo: faster ✔ 7% - 9% (2.23ms - 3.11ms)
    preact-local vs preact-main
  • update10th1k: unsure 🔍 -4% - +2% (-1.18ms - +0.80ms)
    preact-local vs preact-main

usedJSHeapSize

  • create10k: unsure 🔍 +0% - +0% (+0.07ms - +0.09ms)
    preact-local vs preact-main
  • filter-list: slower ❌ 2% - 4% (0.03ms - 0.06ms)
    preact-local vs preact-main
  • hydrate1k: faster ✔ 8% - 17% (0.99ms - 2.32ms)
    preact-local vs preact-main
  • many-updates: faster ✔ 14% - 14% (0.63ms - 0.64ms)
    preact-local vs preact-main
  • replace1k: slower ❌ 1% - 2% (0.03ms - 0.06ms)
    preact-local vs preact-main
  • text-update: slower ❌ 6% - 8% (0.07ms - 0.09ms)
    preact-local vs preact-main
  • todo: slower ❌ 9% - 10% (0.11ms - 0.13ms)
    preact-local vs preact-main
  • update10th1k: faster ✔ 13% - 14% (0.44ms - 0.48ms)
    preact-local vs preact-main

Results

⏳ Benchmarks are currently running. Results below are out of date.
create10k

duration

VersionAvg timevs preact-localvs preact-main
preact-local935.32ms - 942.85ms-unsure 🔍
-0% - +1%
-2.94ms - +6.61ms
preact-main934.32ms - 940.19msunsure 🔍
-1% - +0%
-6.61ms - +2.94ms
-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local24.91ms - 24.92ms-unsure 🔍
+0% - +0%
+0.07ms - +0.09ms
preact-main24.83ms - 24.84msunsure 🔍
-0% - -0%
-0.09ms - -0.07ms
-
filter-list

duration

VersionAvg timevs preact-localvs preact-main
preact-local16.55ms - 16.75ms-unsure 🔍
-0% - +1%
-0.05ms - +0.16ms
preact-main16.56ms - 16.63msunsure 🔍
-1% - +0%
-0.16ms - +0.05ms
-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local1.69ms - 1.70ms-slower ❌
2% - 4%
0.03ms - 0.06ms
preact-main1.63ms - 1.66msfaster ✔
2% - 4%
0.03ms - 0.06ms
-
hydrate1k

duration

VersionAvg timevs preact-localvs preact-main
preact-local72.03ms - 72.83ms-unsure 🔍
-2% - +0%
-1.29ms - +0.25ms
preact-main72.29ms - 73.61msunsure 🔍
-0% - +2%
-0.25ms - +1.29ms
-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local11.08ms - 11.62ms-faster ✔
8% - 17%
0.99ms - 2.32ms
preact-main12.40ms - 13.61msslower ❌
9% - 21%
0.99ms - 2.32ms
-
many-updates
  • Browser: chrome-headless
  • Sample size: 100
  • Built by: CI #4188
  • Commit: 743ed46

duration

VersionAvg timevs preact-localvs preact-main
preact-local16.66ms - 17.26ms-slower ❌
2% - 7%
0.33ms - 1.19ms
preact-main15.89ms - 16.51msfaster ✔
2% - 7%
0.33ms - 1.19ms
-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local3.85ms - 3.86ms-faster ✔
14% - 14%
0.63ms - 0.64ms
preact-main4.49ms - 4.50msslower ❌
16% - 17%
0.63ms - 0.64ms
-
replace1k
  • Browser: chrome-headless
  • Sample size: 100
  • Built by: CI #4188
  • Commit: 743ed46

duration

VersionAvg timevs preact-localvs preact-main
preact-local70.33ms - 71.14ms-slower ❌
4% - 5%
2.41ms - 3.60ms
preact-main67.29ms - 68.17msfaster ✔
3% - 5%
2.41ms - 3.60ms
-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local3.59ms - 3.61ms-slower ❌
1% - 2%
0.03ms - 0.06ms
preact-main3.54ms - 3.57msfaster ✔
1% - 2%
0.03ms - 0.06ms
-

run-warmup-0

VersionAvg timevs preact-localvs preact-main
preact-local31.76ms - 32.44ms-slower ❌
2% - 5%
0.68ms - 1.60ms
preact-main30.65ms - 31.27msfaster ✔
2% - 5%
0.68ms - 1.60ms
-

run-warmup-1

VersionAvg timevs preact-localvs preact-main
preact-local29.07ms - 29.62ms-faster ✔
17% - 20%
5.96ms - 7.27ms
preact-main35.37ms - 36.56msslower ❌
20% - 25%
5.96ms - 7.27ms
-

run-warmup-2

VersionAvg timevs preact-localvs preact-main
preact-local30.16ms - 31.23ms-slower ❌
0% - 5%
0.11ms - 1.45ms
preact-main29.51ms - 30.31msfaster ✔
0% - 5%
0.11ms - 1.45ms
-

run-warmup-3

VersionAvg timevs preact-localvs preact-main
preact-local22.45ms - 22.77ms-faster ✔
4% - 7%
0.95ms - 1.58ms
preact-main23.60ms - 24.15msslower ❌
4% - 7%
0.95ms - 1.58ms
-

run-warmup-4

VersionAvg timevs preact-localvs preact-main
preact-local22.33ms - 23.29ms-slower ❌
2% - 6%
0.40ms - 1.41ms
preact-main21.75ms - 22.07msfaster ✔
2% - 6%
0.40ms - 1.41ms
-

run-final

VersionAvg timevs preact-localvs preact-main
preact-local20.42ms - 20.73ms-unsure 🔍
-2% - +1%
-0.48ms - +0.17ms
preact-main20.44ms - 21.02msunsure 🔍
-1% - +2%
-0.17ms - +0.48ms
-
text-update

duration

VersionAvg timevs preact-localvs preact-main
preact-local2.63ms - 2.94ms-slower ❌
15% - 39%
0.36ms - 0.82ms
preact-main2.03ms - 2.37msfaster ✔
14% - 29%
0.36ms - 0.82ms
-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local1.17ms - 1.19ms-slower ❌
6% - 8%
0.07ms - 0.09ms
preact-main1.09ms - 1.11msfaster ✔
6% - 8%
0.07ms - 0.09ms
-
todo

duration

VersionAvg timevs preact-localvs preact-main
preact-local31.39ms - 31.73ms-faster ✔
7% - 9%
2.23ms - 3.11ms
preact-main33.83ms - 34.63msslower ❌
7% - 10%
2.23ms - 3.11ms
-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local1.32ms - 1.34ms-slower ❌
9% - 10%
0.11ms - 0.13ms
preact-main1.21ms - 1.21msfaster ✔
8% - 9%
0.11ms - 0.13ms
-
update10th1k

duration

VersionAvg timevs preact-localvs preact-main
preact-local32.68ms - 34.25ms-unsure 🔍
-4% - +2%
-1.18ms - +0.80ms
preact-main33.06ms - 34.26msunsure 🔍
-2% - +4%
-0.80ms - +1.18ms
-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local3.00ms - 3.02ms-faster ✔
13% - 14%
0.44ms - 0.48ms
preact-main3.46ms - 3.49msslower ❌
15% - 16%
0.44ms - 0.48ms
-

tachometer-reporter-action v2 for CI

Copy link

github-actions bot commented Nov 23, 2024

Size Change: +6.22 kB (+10.26%) ⚠️

Total Size: 66.8 kB

Filename Size Change
dist/preact.js 5.63 kB +1.05 kB (+22.82%) 🚨
dist/preact.min.js 5.66 kB +1.04 kB (+22.41%) 🚨
dist/preact.min.module.js 5.65 kB +1.04 kB (+22.5%) 🚨
dist/preact.min.umd.js 5.68 kB +1.04 kB (+22.29%) 🚨
dist/preact.module.js 5.64 kB +1.03 kB (+22.4%) 🚨
dist/preact.umd.js 5.71 kB +1.03 kB (+22.11%) 🚨
ℹ️ View Unchanged
Filename Size
compat/dist/compat.js 3.78 kB
compat/dist/compat.module.js 3.7 kB
compat/dist/compat.umd.js 3.84 kB
debug/dist/debug.js 3.83 kB
debug/dist/debug.module.js 3.83 kB
debug/dist/debug.umd.js 3.9 kB
devtools/dist/devtools.js 260 B
devtools/dist/devtools.module.js 274 B
devtools/dist/devtools.umd.js 346 B
hooks/dist/hooks.js 1.52 kB
hooks/dist/hooks.module.js 1.56 kB
hooks/dist/hooks.umd.js 1.6 kB
jsx-runtime/dist/jsxRuntime.js 978 B
jsx-runtime/dist/jsxRuntime.module.js 952 B
jsx-runtime/dist/jsxRuntime.umd.js 1.05 kB
test-utils/dist/testUtils.js 451 B
test-utils/dist/testUtils.module.js 456 B
test-utils/dist/testUtils.umd.js 536 B

compressed-size-action

@JoviDeCroock JoviDeCroock force-pushed the split-mount-patch branch 6 times, most recently from e6542a9 to 9f2fda3 Compare November 23, 2024 09:48
@JoviDeCroock JoviDeCroock mentioned this pull request Nov 24, 2024
@JoviDeCroock JoviDeCroock force-pushed the split-mount-patch branch 4 times, most recently from 35f0cc7 to 2181325 Compare November 24, 2024 13:36
@JoviDeCroock JoviDeCroock force-pushed the split-mount-patch branch 4 times, most recently from 948205b to 743ed46 Compare December 10, 2024 13:20
@JoviDeCroock JoviDeCroock force-pushed the v11-2 branch 2 times, most recently from 5caed5c to 39339b2 Compare December 22, 2024 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant