[jsonproc] Workaround to handle basic special characters #1965
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is a workaround to avoid compilation fails when including special characters in map names #1963 .
pokeemerald/tools/jsonproc
was modified to include some special characters in the list of "bad characters" and implemented some commands to replace them with the better ascii aproximation:This makes that it won't break anymore, although it doesn't grants the correct result yet. It changes
Villa Raíz
forVilla Ra_iz
i.e. however, I run out of ideas. My guess is that the first try to replace a bad character also inserts the character even not having to replace it, but I don't know how to fix it.Discord contact info
Discord: excmojack