Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[jsonproc] Workaround to handle basic special characters #1965

Closed
wants to merge 1 commit into from

Conversation

ExcmoJack
Copy link

@ExcmoJack ExcmoJack commented Dec 8, 2023

Description

This is a workaround to avoid compilation fails when including special characters in map names #1963 .
pokeemerald/tools/jsonproc was modified to include some special characters in the list of "bad characters" and implemented some commands to replace them with the better ascii aproximation:

aChars = "áàâä";
AChars = "ÁÀÂÄ";
eChars = "éèêë";
EChars = "ÉÈÊË";
iChars = "íìîï";
IChars = "ÍÌÎÏ";
oChars = "óòôöœ";
OChars = "ÓÒÔÖŒ";
uChars = "úùûü";
UChars = "ÚÙÛÜ";
nChars = "ñ";
NChars = "Ñ";

This makes that it won't break anymore, although it doesn't grants the correct result yet. It changes Villa Raíz for Villa Ra_iz i.e. however, I run out of ideas. My guess is that the first try to replace a bad character also inserts the character even not having to replace it, but I don't know how to fix it.

Discord contact info

Discord: excmojack

@GriffinRichards
Copy link
Member

Handled for now by #1975

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants