Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#32 - User API 일부 추가 #39

Merged
merged 15 commits into from
Nov 26, 2024
Merged

#32 - User API 일부 추가 #39

merged 15 commits into from
Nov 26, 2024

Conversation

jbw9964
Copy link
Collaborator

@jbw9964 jbw9964 commented Nov 25, 2024

#️⃣연관된 이슈

Related: #32

📝작업 내용

유저가 첫 회원가입 후, 기본 정보 등록과 관련된 API 를 추가하였습니다.

스크린샷 (선택)

캡처2

@jbw9964 jbw9964 added the 📌 feature New feature added label Nov 25, 2024
@jbw9964 jbw9964 self-assigned this Nov 25, 2024
Copy link

github-actions bot commented Nov 25, 2024

Test Results

39 tests   39 ✅  9s ⏱️
11 suites   0 💤
11 files     0 ❌

Results for commit 2af685a.

♻️ This comment has been updated with latest results.

Copy link
Collaborator

@kcsc2217 kcsc2217 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생 많으셨습니다!!

Copy link
Collaborator

@AnTaeho AnTaeho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨습니다! 몇가지 의견이나 궁금한점 남겼습니다!

Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
72.8% Coverage on New Code (required ≥ 80%)
C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

Copy link
Collaborator

@Leehunil Leehunil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Controller Test 코드 배워갑니다!!
잘 작성하신 것 같습니다~

@jbw9964 jbw9964 merged commit 34cb5ec into develop Nov 26, 2024
3 of 4 checks passed
@jbw9964 jbw9964 deleted the feat/#32/user-api branch November 26, 2024 01:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📌 feature New feature added
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants