Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#55 - 아키이브 관련 API 구현 #58

Merged
merged 8 commits into from
Dec 2, 2024
Merged

#55 - 아키이브 관련 API 구현 #58

merged 8 commits into from
Dec 2, 2024

Conversation

AnTaeho
Copy link
Collaborator

@AnTaeho AnTaeho commented Dec 1, 2024

#️⃣연관된 이슈

ex) #이슈번호, #이슈번호

close: #55

📝작업 내용

이번 PR에서 작업한 내용을 간략히 설명해주세요(이미지 첨부 가능)

아카이브 관련 로직 소소하게 수정했습니다.
추가로 댓글 수정 기능 추가했습니다

스크린샷 (선택)

💬리뷰 요구사항(선택)

리뷰어가 특별히 봐주었으면 하는 부분이 있다면 작성해주세요

ex) 메서드 XXX의 이름을 더 잘 짓고 싶은데 혹시 좋은 명칭이 있을까요?

@AnTaeho AnTaeho added the 📌 feature New feature added label Dec 1, 2024
@AnTaeho AnTaeho self-assigned this Dec 1, 2024
@AnTaeho AnTaeho linked an issue Dec 1, 2024 that may be closed by this pull request
[FIX] 아카이브 관련 로직 수정 #55
Closed
3 tasks
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 1, 2024 •
edited
Loading

Test Results

14 files  14 suites   14s ⏱️
59 tests 59 ✅ 0 💤 0 ❌
60 runs  60 ✅ 0 💤 0 ❌

Results for commit e78b55b.

♻️ This comment has been updated with latest results.

jbw9964
jbw9964 approved these changes Dec 2, 2024
View reviewed changes
Copy link
Collaborator

@jbw9964 jbw9964 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고하셨습니다! 한가지 궁금한 점 있습니다!

src/main/java/com/palettee/archive/service/ArchiveService.java Show resolved Hide resolved
kcsc2217
kcsc2217 approved these changes Dec 2, 2024
View reviewed changes
Copy link
Collaborator

@kcsc2217 kcsc2217 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생많으셨습니다!!!

@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Dec 2, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
67.8% Coverage on New Code (required ≥ 80%)
C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

@AnTaeho AnTaeho merged commit af9aa2a into develop Dec 2, 2024
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kcsc2217 kcsc2217 kcsc2217 approved these changes

@jbw9964 jbw9964 jbw9964 approved these changes

@Leehunil Leehunil Awaiting requested review from Leehunil

Assignees

@AnTaeho AnTaeho

Labels
📌 feature New feature added
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FIX] 아카이브 관련 로직 수정
3 participants
@AnTaeho @jbw9964 @kcsc2217