Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add design guidelines #497

Merged
merged 19 commits into from
Oct 22, 2020
Merged

Add design guidelines #497

merged 19 commits into from
Oct 22, 2020

Conversation

colebemis
Copy link
Contributor

@colebemis colebemis commented Sep 10, 2020 •
edited by ashygee
Loading

This PR adds usage and design guidelines to the Octicons website.

Preview link 👀

References

@vercel
Copy link

vercel bot commented Sep 10, 2020 •
edited
Loading

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/primer/octicons/ohpz6sqrs
✅ Preview: https://octicons-git-guidelines.primer.now.sh

@vercel vercel bot temporarily deployed to Preview September 10, 2020 05:19 Inactive
@vercel vercel bot temporarily deployed to Preview September 16, 2020 16:46 Inactive
@vercel vercel bot temporarily deployed to Preview September 16, 2020 21:05 Inactive
@vercel vercel bot temporarily deployed to Preview September 16, 2020 23:22 Inactive
@vercel vercel bot temporarily deployed to Preview September 17, 2020 21:11 Inactive
yaili
yaili reviewed Sep 22, 2020
View reviewed changes
Copy link
Member

@yaili yaili left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a few comments. Looking good! 👍🏼

docs/content/guidelines/design.mdx Show resolved Hide resolved
docs/content/guidelines/design.mdx Outdated Show resolved Hide resolved
docs/content/guidelines/design.mdx Show resolved Hide resolved
docs/content/guidelines/design.mdx Show resolved Hide resolved
@vercel vercel bot temporarily deployed to Preview September 23, 2020 16:26 Inactive
@vercel vercel bot temporarily deployed to Preview September 23, 2020 16:38 Inactive
@vercel vercel bot temporarily deployed to Preview September 23, 2020 16:45 Inactive
@vercel vercel bot temporarily deployed to Preview September 23, 2020 16:46 Inactive
@colebemis colebemis changed the title [WIP] Add guidelines Add guidelines Sep 23, 2020
@colebemis colebemis changed the title Add guidelines Add usage and design guidelines Sep 23, 2020
@colebemis colebemis marked this pull request as ready for review September 23, 2020 16:51
@colebemis colebemis requested a review from yaili September 23, 2020 16:51
@vercel vercel bot temporarily deployed to Preview September 23, 2020 17:26 Inactive
yaili
yaili approved these changes Sep 23, 2020
View reviewed changes
Copy link
Member

@yaili yaili left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏼 Looks good. Just needs the gif alt, as discussed. 🙂

@vercel vercel bot temporarily deployed to Preview September 23, 2020 18:46 Inactive
@colebemis colebemis mentioned this pull request Sep 24, 2020
Merged
@vercel vercel bot temporarily deployed to Preview September 29, 2020 21:01 Inactive
@vercel vercel bot temporarily deployed to Preview October 1, 2020 20:32 Inactive
@vercel vercel bot temporarily deployed to Preview October 1, 2020 22:54 Inactive
@ashygee ashygee changed the title Add usage and design guidelines Add design guidelines Oct 22, 2020
@ashygee
Copy link
Contributor

ashygee commented Oct 22, 2020

Changed the name and removed usage guidelines in this PR as we are going to separate the two and add usage guidelines separately in a follow up PR.

@vercel vercel bot temporarily deployed to Preview October 22, 2020 18:20 Inactive
@vercel vercel bot temporarily deployed to Preview October 22, 2020 18:45 Inactive
@vercel vercel bot temporarily deployed to Preview October 22, 2020 18:49 Inactive
@vercel vercel bot temporarily deployed to Preview October 22, 2020 18:52 Inactive
@colebemis colebemis merged commit da358d9 into master Oct 22, 2020
@colebemis colebemis deleted the guidelines branch October 22, 2020 19:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yaili yaili yaili approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@colebemis @ashygee @yaili