-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow to keep some tokens in output as references #1100
Conversation
🦋 Changeset detectedLatest commit: 31aed64 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Design Token Diff (CSS)The message is too long to be displayed here. For more details, please check the job summary. |
0f97987
to
dd3accb
Compare
Current bug: Style dictionaries The output for shadows now has a color value that is: --shadow-floating-xlarge: 0px 0px 0px 1px #d1d9e0,
0px 56px 112px 0px var(--base-color-neutral-12) 52; /* <- this 52 is the problem */ I am currently in contact with the folks from Style Dictionary to figure this out. |
This comment was marked as resolved.
This comment was marked as resolved.
dd3accb
to
31aed64
Compare
Design Token Diff (StyleLint)The message is too long to be displayed here. For more details, please check the job summary. |
Summary
This PR makes changes to the way references are used in the css platform. Now, all referenced tokens that are in the output will be used as references, while base tokens that are not in the output will be converted to hex values.
Impact
This work enables a lot of use cases related to customization including.
In short, this update allows us to change design tokens (e.g. colors, text sizes, contrast, etc.) in the browser (e.g. user settings) that will propagate through all of github.
For example:
success
states