Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix open state color for colorblind #1136

Merged
merged 3 commits into from
Dec 18, 2024

Conversation

lukasoppermann
Copy link
Contributor

Summary

List of notable changes:

What should reviewers focus on?

Steps to test:

Copy link

changeset-bot bot commented Dec 17, 2024

🦋 Changeset detected

Latest commit: 8490854

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/primitives Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Dec 17, 2024

Design Token Diff (CSS)

/css/functional/themes/dark-colorblind.css

+++ /home/runner/work/primitives/primitives/dist/css/functional/themes/dark-colorblind.css	2024-12-18 08:28:37.992209247 +0000
@@ -30,8 +30,8 @@
 --bgColor-muted: #151b23;
 --bgColor-neutral-emphasis: #656c76;
 --bgColor-neutral-muted: #656c7633;
-  --bgColor-open-emphasis: #bd561d;
-  --bgColor-open-muted: #db6d2833;
+  --bgColor-open-emphasis: #1f6feb;
+  --bgColor-open-muted: #388bfd33;
 --bgColor-severe-emphasis: #bd561d;
 --bgColor-severe-muted: #db6d281a;
 --bgColor-sponsors-emphasis: #bf4b8a;
@@ -50,8 +50,8 @@
 --borderColor-done-emphasis: #8957e5;
 --borderColor-done-muted: #ab7df866;
 --borderColor-emphasis: #656c76;
-  --borderColor-open-emphasis: #db6d28;
-  --borderColor-open-muted: #db6d2866;
+  --borderColor-open-emphasis: #388bfd;
+  --borderColor-open-muted: #388bfd66;
 --borderColor-severe-emphasis: #bd561d;
 --borderColor-severe-muted: #db6d2866;
 --borderColor-sponsors-emphasis: #bf4b8a;
@@ -284,7 +284,7 @@
 --fgColor-link: var(--fgColor-accent);
 --fgColor-muted: #9198a1;
 --fgColor-neutral: #9198a1;
-  --fgColor-open: #f0883e;
+  --fgColor-open: #58a6ff;
 --fgColor-severe: #db6d28;
 --fgColor-sponsors: #db61a2;
 --fgColor-success: #58a6ff;
@@ -636,8 +636,8 @@
   --bgColor-muted: #151b23;
   --bgColor-neutral-emphasis: #656c76;
   --bgColor-neutral-muted: #656c7633;
-    --bgColor-open-emphasis: #bd561d;
-    --bgColor-open-muted: #db6d2833;
+    --bgColor-open-emphasis: #1f6feb;
+    --bgColor-open-muted: #388bfd33;
   --bgColor-severe-emphasis: #bd561d;
   --bgColor-severe-muted: #db6d281a;
   --bgColor-sponsors-emphasis: #bf4b8a;
@@ -656,8 +656,8 @@
   --borderColor-done-emphasis: #8957e5;
   --borderColor-done-muted: #ab7df866;
   --borderColor-emphasis: #656c76;
-    --borderColor-open-emphasis: #db6d28;
-    --borderColor-open-muted: #db6d2866;
+    --borderColor-open-emphasis: #388bfd;
+    --borderColor-open-muted: #388bfd66;
   --borderColor-severe-emphasis: #bd561d;
   --borderColor-severe-muted: #db6d2866;
   --borderColor-sponsors-emphasis: #bf4b8a;
@@ -890,7 +890,7 @@
   --fgColor-link: var(--fgColor-accent);
   --fgColor-muted: #9198a1;
   --fgColor-neutral: #9198a1;
-    --fgColor-open: #f0883e;
+    --fgColor-open: #58a6ff;
   --fgColor-severe: #db6d28;
   --fgColor-sponsors: #db61a2;
   --fgColor-success: #58a6ff;

/css/functional/themes/light-colorblind.css

+++ /home/runner/work/primitives/primitives/dist/css/functional/themes/light-colorblind.css	2024-12-18 08:28:32.840173911 +0000
@@ -29,8 +29,8 @@
 --bgColor-muted: #f6f8fa;
 --bgColor-neutral-emphasis: #59636e;
 --bgColor-neutral-muted: #818b981f;
-  --bgColor-open-emphasis: #bc4c00;
-  --bgColor-open-muted: #fff1e5;
+  --bgColor-open-emphasis: #0969da;
+  --bgColor-open-muted: #ddf4ff;
 --bgColor-severe-emphasis: #bc4c00;
 --bgColor-severe-muted: #fff1e5;
 --bgColor-sponsors-emphasis: #bf3989;
@@ -50,8 +50,8 @@
 --borderColor-done-muted: #c297ff66;
 --borderColor-emphasis: #818b98;
 --borderColor-neutral-emphasis: #59636e;
-  --borderColor-open-emphasis: #e16f24;
-  --borderColor-open-muted: #fb8f4466;
+  --borderColor-open-emphasis: #218bff;
+  --borderColor-open-muted: #54aeff66;
 --borderColor-severe-emphasis: #bc4c00;
 --borderColor-severe-muted: #fb8f4466;
 --borderColor-sponsors-emphasis: #bf3989;
@@ -266,7 +266,7 @@
 --fgColor-done: #8250df;
 --fgColor-muted: #59636e;
 --fgColor-neutral: #59636e;
-  --fgColor-open: #bc4c00;
+  --fgColor-open: #0969da;
 --fgColor-severe: #bc4c00;
 --fgColor-sponsors: #bf3989;
 --fgColor-success: #0969da;
@@ -635,8 +635,8 @@
   --bgColor-muted: #f6f8fa;
   --bgColor-neutral-emphasis: #59636e;
   --bgColor-neutral-muted: #818b981f;
-    --bgColor-open-emphasis: #bc4c00;
-    --bgColor-open-muted: #fff1e5;
+    --bgColor-open-emphasis: #0969da;
+    --bgColor-open-muted: #ddf4ff;
   --bgColor-severe-emphasis: #bc4c00;
   --bgColor-severe-muted: #fff1e5;
   --bgColor-sponsors-emphasis: #bf3989;
@@ -656,8 +656,8 @@
   --borderColor-done-muted: #c297ff66;
   --borderColor-emphasis: #818b98;
   --borderColor-neutral-emphasis: #59636e;
-    --borderColor-open-emphasis: #e16f24;
-    --borderColor-open-muted: #fb8f4466;
+    --borderColor-open-emphasis: #218bff;
+    --borderColor-open-muted: #54aeff66;
   --borderColor-severe-emphasis: #bc4c00;
   --borderColor-severe-muted: #fb8f4466;
   --borderColor-sponsors-emphasis: #bf3989;
@@ -872,7 +872,7 @@
   --fgColor-done: #8250df;
   --fgColor-muted: #59636e;
   --fgColor-neutral: #59636e;
-    --fgColor-open: #bc4c00;
+    --fgColor-open: #0969da;
   --fgColor-severe: #bc4c00;
   --fgColor-sponsors: #bf3989;
   --fgColor-success: #0969da;

Copy link
Contributor

github-actions bot commented Dec 17, 2024

Design Token Diff (StyleLint)

/styleLint/functional/themes/dark-colorblind.json

+++ /home/runner/work/primitives/primitives/dist/styleLint/functional/themes/dark-colorblind.json	2024-12-18 08:28:37.992209247 +0000
@@ -697,12 +697,12 @@
   "key": "{bgColor.neutral.muted}"
 },
 "bgColor-open-emphasis": {
-    "$value": "#bd561d",
+    "$value": "#1f6feb",
   "$type": "color",
   "filePath": "src/tokens/functional/color/dark/overrides/dark.protanopia-deuteranopia.json5",
   "isSource": true,
   "original": {
-      "$value": "{base.color.orange.5}",
+      "$value": "{base.color.blue.5}",
     "$type": "color"
   },
   "name": "bgColor-open-emphasis",
@@ -711,13 +711,13 @@
   "key": "{bgColor.open.emphasis}"
 },
 "bgColor-open-muted": {
-    "$value": "#db6d2833",
+    "$value": "#388bfd33",
   "$type": "color",
   "alpha": 0.2,
   "filePath": "src/tokens/functional/color/dark/overrides/dark.protanopia-deuteranopia.json5",
   "isSource": true,
   "original": {
-      "$value": "{base.color.orange.4}",
+      "$value": "{base.color.blue.4}",
     "$type": "color",
     "alpha": 0.2
   },
@@ -1953,12 +1953,12 @@
   "key": "{borderColor.neutral.muted}"
 },
 "borderColor-open-emphasis": {
-    "$value": "#db6d28",
+    "$value": "#388bfd",
   "$type": "color",
   "filePath": "src/tokens/functional/color/dark/overrides/dark.protanopia-deuteranopia.json5",
   "isSource": true,
   "original": {
-      "$value": "{base.color.orange.4}",
+      "$value": "{base.color.blue.4}",
     "$type": "color"
   },
   "name": "borderColor-open-emphasis",
@@ -1967,13 +1967,13 @@
   "key": "{borderColor.open.emphasis}"
 },
 "borderColor-open-muted": {
-    "$value": "#db6d2866",
+    "$value": "#388bfd66",
   "$type": "color",
   "alpha": 0.4,
   "filePath": "src/tokens/functional/color/dark/overrides/dark.protanopia-deuteranopia.json5",
   "isSource": true,
   "original": {
-      "$value": "{base.color.orange.4}",
+      "$value": "{base.color.blue.4}",
     "$type": "color",
     "alpha": 0.4
   },
@@ -11691,12 +11691,12 @@
   "key": "{fgColor.onInverse}"
 },
 "fgColor-open": {
-    "$value": "#f0883e",
+    "$value": "#58a6ff",
   "$type": "color",
   "filePath": "src/tokens/functional/color/dark/overrides/dark.protanopia-deuteranopia.json5",
   "isSource": true,
   "original": {
-      "$value": "{base.color.orange.3}",
+      "$value": "{base.color.blue.3}",
     "$type": "color"
   },
   "name": "fgColor-open",

/styleLint/functional/themes/light-colorblind.json

+++ /home/runner/work/primitives/primitives/dist/styleLint/functional/themes/light-colorblind.json	2024-12-18 08:28:32.840173911 +0000
@@ -685,12 +685,12 @@
   "key": "{bgColor.neutral.muted}"
 },
 "bgColor-open-emphasis": {
-    "$value": "#bc4c00",
+    "$value": "#0969da",
   "$type": "color",
   "filePath": "src/tokens/functional/color/light/overrides/light.protanopia-deuteranopia.json5",
   "isSource": true,
   "original": {
-      "$value": "{base.color.orange.5}",
+      "$value": "{base.color.blue.5}",
     "$type": "color"
   },
   "name": "bgColor-open-emphasis",
@@ -699,12 +699,12 @@
   "key": "{bgColor.open.emphasis}"
 },
 "bgColor-open-muted": {
-    "$value": "#fff1e5",
+    "$value": "#ddf4ff",
   "$type": "color",
   "filePath": "src/tokens/functional/color/light/overrides/light.protanopia-deuteranopia.json5",
   "isSource": true,
   "original": {
-      "$value": "{base.color.orange.0}",
+      "$value": "{base.color.blue.0}",
     "$type": "color"
   },
   "name": "bgColor-open-muted",
@@ -1931,12 +1931,12 @@
   "key": "{borderColor.neutral.muted}"
 },
 "borderColor-open-emphasis": {
-    "$value": "#e16f24",
+    "$value": "#218bff",
   "$type": "color",
   "filePath": "src/tokens/functional/color/light/overrides/light.protanopia-deuteranopia.json5",
   "isSource": true,
   "original": {
-      "$value": "{base.color.orange.4}",
+      "$value": "{base.color.blue.4}",
     "$type": "color"
   },
   "name": "borderColor-open-emphasis",
@@ -1945,13 +1945,13 @@
   "key": "{borderColor.open.emphasis}"
 },
 "borderColor-open-muted": {
-    "$value": "#fb8f4466",
+    "$value": "#54aeff66",
   "$type": "color",
   "alpha": 0.4,
   "filePath": "src/tokens/functional/color/light/overrides/light.protanopia-deuteranopia.json5",
   "isSource": true,
   "original": {
-      "$value": "{base.color.orange.3}",
+      "$value": "{base.color.blue.3}",
     "$type": "color",
     "alpha": 0.4
   },
@@ -11747,12 +11747,12 @@
   "key": "{fgColor.onInverse}"
 },
 "fgColor-open": {
-    "$value": "#bc4c00",
+    "$value": "#0969da",
   "$type": "color",
   "filePath": "src/tokens/functional/color/light/overrides/light.protanopia-deuteranopia.json5",
   "isSource": true,
   "original": {
-      "$value": "{base.color.orange.5}",
+      "$value": "{base.color.blue.5}",
     "$type": "color"
   },
   "name": "fgColor-open",

@github-actions github-actions bot temporarily deployed to Preview (Storybook) December 17, 2024 16:06 Inactive
@langermank langermank changed the title Fix open state color for colorbling Fix open state color for colorblind Dec 17, 2024
@lukasoppermann lukasoppermann added the update snapshots Update visual regression test snapshots label Dec 18, 2024
@github-actions github-actions bot temporarily deployed to Preview (Storybook) December 18, 2024 07:57 Inactive
@github-actions github-actions bot removed the update snapshots Update visual regression test snapshots label Dec 18, 2024
@github-actions github-actions bot temporarily deployed to Preview (Storybook) December 18, 2024 08:30 Inactive
@lukasoppermann lukasoppermann merged commit 3e281b1 into main Dec 18, 2024
27 checks passed
@lukasoppermann lukasoppermann deleted the @lukasoppermann/dark-theme-open-fix branch December 18, 2024 10:31
@primer primer bot mentioned this pull request Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant