Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: project addition by salmasyed19 #603 #2670

Merged
merged 2 commits into from
Jan 4, 2025

Conversation

salmasyed1909
Copy link
Contributor

Related Issue

Description

Screenshots

Signed-off-by:  salma syed <112183807+salmasyed1909@users.noreply.github.com>
@github-actions github-actions bot added projects addition add your projects wait for reviewers wait for the maintainer labels Jan 4, 2025
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job, @salmasyed1909! 🎉 Thank you for submitting your first pull request. Your contribution is valuable and we appreciate your efforts to improve our project.

We will promptly review your changes and offer feedback. Keep up the excellent work! Kindly remember to check our contributing guidelines

@salmasyed1909 salmasyed1909 changed the title docs: project added chore: project addition by salmasyed19 #603 Jan 4, 2025
@salmasyed1909
Copy link
Contributor Author

@priyankarpal Hi! Could you kindly review and approve my PR when you have time? Thanks! 😊

Signed-off-by:  salma syed <112183807+salmasyed1909@users.noreply.github.com>
Comment on lines +30 to 45
"github_username": "salmasyed1909",
"Projects": [
{
"github_url": "https://github.com/salmasyed1909/chatbot-project",
"title": "Chatbot-project",
"description": "mini chatbot",
"tech": ["python","NLP","Machine learning"]
},
{
"github_url": "https://github.com/salmasyed1909/MY_PORTFOLIO",
"title": "portfolio",
"description": "DEScribes about me",
"tech": ["HTML","CSS","JavaScript"]
}
]
},
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

review

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me 👏🏻

@priyankarpal priyankarpal merged commit 8e08e68 into priyankarpal:main Jan 4, 2025
7 checks passed
@salmasyed1909 salmasyed1909 deleted the patch-1 branch January 4, 2025 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
projects addition add your projects wait for reviewers wait for the maintainer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants